From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12571 invoked by alias); 5 Dec 2003 00:22:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12550 invoked from network); 5 Dec 2003 00:22:56 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 5 Dec 2003 00:22:56 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id ABF2647D61; Thu, 4 Dec 2003 16:22:58 -0800 (PST) Date: Fri, 05 Dec 2003 00:22:00 -0000 From: Joel Brobecker To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] stabs: remember types that cross reference another type Message-ID: <20031205002258.GJ1652@gnat.com> References: <20031031200851.GD1236@gnat.com> <20031103225952.GA2412@gnat.com> <16334.50206.868506.409948@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16334.50206.868506.409948@localhost.redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2003-12/txt/msg00160.txt.bz2 > Yes, but the comment before that loop you are changing needs some > revamping. Reading it, it really looks like it is a useless/obsoleted > thing we are doing here, while now it's not the case anymore. I mean, > it is useful. yes, I agree. I am not sure how much information to keep though. Would the following be ok? /* If this type has already been declared, then reuse the same type rather than allocating a new one. This saves some memory. */ The current comment is: /* Now check to see whether the type has already been declared. This was written for arrays of cross-referenced types before we had TYPE_CODE_TARGET_STUBBED, so I'm pretty sure it is not necessary anymore. But it might be a good idea, to save a little memory. */ -- Joel