From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24864 invoked by alias); 4 Dec 2003 23:53:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24854 invoked from network); 4 Dec 2003 23:53:47 -0000 Received: from unknown (HELO faui10.informatik.uni-erlangen.de) (131.188.31.10) by sources.redhat.com with SMTP; 4 Dec 2003 23:53:47 -0000 Received: from faui1d.informatik.uni-erlangen.de (faui1d [131.188.31.34]) by faui10.informatik.uni-erlangen.de (8.9.3p3/8.1.9-FAU) with ESMTP id AAA25394; Fri, 5 Dec 2003 00:53:45 +0100 (CET) From: Ulrich Weigand Received: (from weigand@localhost) by faui1d.informatik.uni-erlangen.de (8.9.3p3/8.1.6-FAU) id AAA07925; Fri, 5 Dec 2003 00:53:45 +0100 (CET) Message-Id: <200312042353.AAA07925@faui1d.informatik.uni-erlangen.de> Subject: Re: [PATCH] S/390 port modernization 2/4 To: jimb@redhat.com (Jim Blandy) Date: Thu, 04 Dec 2003 23:53:00 -0000 Cc: weigand@i1.informatik.uni-erlangen.de (Ulrich Weigand), gdb-patches@sources.redhat.com, uweigand@de.ibm.com In-Reply-To: from "Jim Blandy" at Dec 04, 2003 05:25:33 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00158.txt.bz2 Jim Blandy wrote: > Is this correct? Since CORE_ADDR is unsigned, the initial value of > watch_hi_addr will compare greater than any watch area's hi_addr, so > the 'max' will never change its value. Same for watch_lo_addr. Don't > you want to set watch_lo_addr to (CORE_ADDR) -1, and watch_hi_addr to > 0? D'oh. Thanks for noticing this. Will fix. Bye, Ulrich -- Dr. Ulrich Weigand weigand@informatik.uni-erlangen.de