From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28935 invoked by alias); 4 Dec 2003 23:04:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28920 invoked from network); 4 Dec 2003 23:04:08 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.81.54.130) by sources.redhat.com with SMTP; 4 Dec 2003 23:04:08 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id BCE6D357B; Thu, 4 Dec 2003 15:04:07 -0800 (PST) Received: from magilla.sf.frob.com (localhost.localdomain [127.0.0.1]) by magilla.sf.frob.com (8.12.9/8.12.9) with ESMTP id hB4N47Hi017056; Thu, 4 Dec 2003 15:04:07 -0800 Received: (from roland@localhost) by magilla.sf.frob.com (8.12.9/8.12.9/Submit) id hB4N46f2017052; Thu, 4 Dec 2003 15:04:06 -0800 Date: Thu, 04 Dec 2003 23:04:00 -0000 Message-Id: <200312042304.hB4N46f2017052@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] fix error reporting for td_ta_event_addr calls In-Reply-To: Mark Kettenis's message of Wednesday, 3 December 2003 18:23:44 +0100 <200312031723.hB3HNir5004833@elgar.kettenis.dyndns.org> X-Antipastobozoticataclysm: When George Bush projectile vomits antipasto on the Japanese. X-SW-Source: 2003-12/txt/msg00155.txt.bz2 > Date: Tue, 2 Dec 2003 18:51:59 -0800 > From: Roland McGrath > > As it stands, if the libthread_db function td_ta_event_addr fails, > gdb will report "warning: Unable to get location for thread creation > breakpoint: generic 'call succeeded'", having discarded the actual error > code from the function. This patch fixes that. > > Approved to commit? > > Looks good to me, so, yes please! Committed yesterday, sorry I forgot to post then. > Mark > > 2003-12-02 Roland McGrath > > * thread-db.c (enable_thread_event): Change return type to > td_err_e. Return TD_OK or error code. > (enable_thread_event_reporting): Update callers.