From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24743 invoked by alias); 4 Dec 2003 22:11:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24674 invoked from network); 4 Dec 2003 22:11:50 -0000 Received: from unknown (HELO faui10.informatik.uni-erlangen.de) (131.188.31.10) by sources.redhat.com with SMTP; 4 Dec 2003 22:11:50 -0000 Received: from faui1d.informatik.uni-erlangen.de (faui1d [131.188.31.34]) by faui10.informatik.uni-erlangen.de (8.9.3p3/8.1.9-FAU) with ESMTP id XAA24102; Thu, 4 Dec 2003 23:11:48 +0100 (CET) From: Ulrich Weigand Received: (from weigand@localhost) by faui1d.informatik.uni-erlangen.de (8.9.3p3/8.1.6-FAU) id XAA07877; Thu, 4 Dec 2003 23:11:48 +0100 (CET) Message-Id: <200312042211.XAA07877@faui1d.informatik.uni-erlangen.de> Subject: Re: [PATCH] S/390 port modernization 1/4 To: jimb@redhat.com (Jim Blandy) Date: Thu, 04 Dec 2003 22:11:00 -0000 Cc: weigand@i1.informatik.uni-erlangen.de (Ulrich Weigand), gdb-patches@sources.redhat.com, uweigand@de.ibm.com In-Reply-To: from "Jim Blandy" at Dec 04, 2003 04:41:32 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00148.txt.bz2 Jim Blandy wrote: > The regset_from_core_section stuff is done exactly the way the i386 > and x86-64 do it, so I won't criticize it. But there are two things I > wonder about: > > - Since core file formats are really OS-specific (ABI's often don't > specify them), wouldn't it make more sense for the *-nat.c file to > register an OS/ABI handler, and have that handler register the > regset_from_core_section method? Defining the core file format in *-nat.c would mean that a cross-gdb wouldn't understand core files, right? > - Why does everyone allocate the 'struct regset' objects dynamically? > The regset layouts are structures in header files, so there's only a > static set of them; one could simply define initialized instances of > 'struct regset', and the regset_from_core_section method could > return them. That seems simpler than allocating them dynamically, > and caching them in the tdep structure. OK, I'll change that. Bye, Ulrich -- Dr. Ulrich Weigand weigand@informatik.uni-erlangen.de