From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2284 invoked by alias); 3 Dec 2003 17:24:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2222 invoked from network); 3 Dec 2003 17:23:59 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 3 Dec 2003 17:23:59 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id hB3HNmOK000240; Wed, 3 Dec 2003 18:23:48 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id hB3HNmi2004836; Wed, 3 Dec 2003 18:23:48 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id hB3HNir5004833; Wed, 3 Dec 2003 18:23:44 +0100 (CET) Date: Wed, 03 Dec 2003 17:24:00 -0000 Message-Id: <200312031723.hB3HNir5004833@elgar.kettenis.dyndns.org> From: Mark Kettenis To: roland@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <200312030251.hB32pxHO021802@magilla.sf.frob.com> (message from Roland McGrath on Tue, 2 Dec 2003 18:51:59 -0800) Subject: Re: [PATCH] fix error reporting for td_ta_event_addr calls References: <200312030251.hB32pxHO021802@magilla.sf.frob.com> X-SW-Source: 2003-12/txt/msg00081.txt.bz2 Date: Tue, 2 Dec 2003 18:51:59 -0800 From: Roland McGrath As it stands, if the libthread_db function td_ta_event_addr fails, gdb will report "warning: Unable to get location for thread creation breakpoint: generic 'call succeeded'", having discarded the actual error code from the function. This patch fixes that. Approved to commit? Looks good to me, so, yes please! Mark 2003-12-02 Roland McGrath * thread-db.c (enable_thread_event): Change return type to td_err_e. Return TD_OK or error code. (enable_thread_event_reporting): Update callers.