From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7047 invoked by alias); 1 Dec 2003 16:39:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7021 invoked from network); 1 Dec 2003 16:39:06 -0000 Received: from unknown (HELO fred.ninemoons.com) (68.14.214.217) by sources.redhat.com with SMTP; 1 Dec 2003 16:39:06 -0000 Received: from fred.ninemoons.com (fred.ninemoons.com [127.0.0.1]) by fred.ninemoons.com (8.12.8/8.12.8) with ESMTP id hB1GcwXj010267; Mon, 1 Dec 2003 09:38:59 -0700 Received: (from fnf@localhost) by fred.ninemoons.com (8.12.8/8.12.8/Submit) id hB1GcwTk010265; Mon, 1 Dec 2003 09:38:58 -0700 From: Fred Fish Message-Id: <200312011638.hB1GcwTk010265@fred.ninemoons.com> Subject: Re: [PATCH] Outwit compiler dead code elimination in break.exp test To: ezannoni@redhat.com (Elena Zannoni) Date: Mon, 01 Dec 2003 16:39:00 -0000 Cc: fnf@ninemoons.com, gdb-patches@sources.redhat.com Reply-To: fnf@ninemoons.com In-Reply-To: <16331.25172.341946.691722@localhost.redhat.com> from "Elena Zannoni" at Dec 01, 2003 10:46:28 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00012.txt.bz2 > > > Why this? The line numbers were not really hardcoded. > > However I can revert that part of the patch if that is an issue. > If the pass/fil messages are unique within the .exp files, then ok. The messages will now be something like: PASS: gdb.base/break.exp: set to-be-silent break bp_location1 instead of: PASS: gdb.base/break.exp: set to-be-silent break 83 and of course bp_location1 can always be matched back up with the actual line number and specific test that failed. -Fred