From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18890 invoked by alias); 1 Dec 2003 15:30:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18707 invoked from network); 1 Dec 2003 15:29:55 -0000 Received: from unknown (HELO fred.ninemoons.com) (68.14.214.217) by sources.redhat.com with SMTP; 1 Dec 2003 15:29:55 -0000 Received: from fred.ninemoons.com (fred.ninemoons.com [127.0.0.1]) by fred.ninemoons.com (8.12.8/8.12.8) with ESMTP id hB1FTIXj010075; Mon, 1 Dec 2003 08:29:18 -0700 Received: from localhost (localhost [[UNIX: localhost]]) by fred.ninemoons.com (8.12.8/8.12.8/Submit) id hB1FTImT010073; Mon, 1 Dec 2003 08:29:18 -0700 From: Fred Fish Reply-To: fnf@ninemoons.com To: Elena Zannoni Subject: Re: [PATCH] Outwit compiler dead code elimination in break.exp test Date: Mon, 01 Dec 2003 15:30:00 -0000 User-Agent: KMail/1.5 Cc: drow@mvista.com (Daniel Jacobowitz), fnf@public.ninemoons.com (Fred Fish), gdb-patches@sources.redhat.com References: <20031130010728.GA26601@nevyn.them.org> <200312010045.hB10jRfd009645@fred.ninemoons.com> <16331.22272.699163.648252@localhost.redhat.com> In-Reply-To: <16331.22272.699163.648252@localhost.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200312010829.17695.fnf@ninemoons.com> X-SW-Source: 2003-12/txt/msg00007.txt.bz2 > > Emit bp_locationNN markers in pass > > and fail messages instead of line numbers. > > Why this? The line numbers were not really hardcoded. Generally I believe you should not emit values in the pass/fail messages that are subject to change, such as addresses, line numbers, etc. This way you can diff successive summary files without seeing spurious differences. However I can revert that part of the patch if that is an issue. -Fred