From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3205 invoked by alias); 26 Nov 2003 04:26:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3184 invoked from network); 26 Nov 2003 04:26:53 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 26 Nov 2003 04:26:53 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AOrGP-0001A4-CI for ; Tue, 25 Nov 2003 23:26:53 -0500 Date: Wed, 26 Nov 2003 04:26:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [rfa/threads] Convert thread event descriptors to code addrs Message-ID: <20031126042653.GA4448@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <200311252300.hAPN016N015872@magilla.sf.frob.com> <3FC3E83E.6090805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FC3E83E.6090805@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00591.txt.bz2 On Tue, Nov 25, 2003 at 06:39:42PM -0500, Andrew Cagney wrote: > In the light of roland's comments, I've checked in the attached > variation on the original patch. > > It still does the conversion but in GDB's libthread_db caller > (enable_thread_event_reporting) and not in libthread_db's symbol lookup > callee (ps_pglobal_lookup). > > This way, libthread_db is free to search for either: > .__nptl_create_event: the start address > __nptl_create_event: the descriptor > (the original change would have restricted searches to just the start > address - not a problem now but we never know) and at the same time > ensure that GDB sets breakpoints at the address it needs. > > Andrew > 2003-11-25 Andrew Cagney > > * thread-db.c (enable_thread_event): New function. Ensure that BP > is a code address. > (enable_thread_event_reporting): Use enable_thread_event. Hmm. Does this mean remote_lookup_symbol (spelling?) should do the same thing? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer