Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: drow@mvista.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Don't use runto_main in i386-unwind.exp
Date: Sun, 23 Nov 2003 20:51:00 -0000	[thread overview]
Message-ID: <200311232050.hANKoRPN009597@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20031123203105.GA21805@nevyn.them.org> (message from Daniel Jacobowitz on Sun, 23 Nov 2003 15:31:05 -0500)

   Date: Sun, 23 Nov 2003 15:31:05 -0500
   From: Daniel Jacobowitz <drow@mvista.com>

   On Sun, Nov 23, 2003 at 08:37:04PM +0100, Mark Kettenis wrote:
   > There is no real reson to use runto_main in this testcase, so I
   > removed it.
   > 
   > Committed,
   > 
   > Mark

   Please don't do this.  runto_main works (suboptimally, but it works)
   for remote targets which use a "target foo; load; continue" sequence,
   but "run" doesn't.

   How about gdb_run_cmd followed by a gdb_expect looking for the SIGTRAP?

Like the attached patch?  Works for me.

Mark


Index: testsuite/gdb.arch/i386-unwind.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-unwind.exp,v
retrieving revision 1.2
diff -u -p -r1.2 i386-unwind.exp
--- testsuite/gdb.arch/i386-unwind.exp 23 Nov 2003 19:30:52 -0000 1.2
+++ testsuite/gdb.arch/i386-unwind.exp 23 Nov 2003 20:49:39 -0000
@@ -47,8 +47,19 @@ gdb_load ${binfile}
 
 # Testcase for backtrace/1435.
 
-gdb_test "run" "Program received signal SIGTRAP.*" \
-         "run past gdb1435"
+gdb_run_cmd
+
+gdb_expect {
+    -re "Program received signal SIGTRAP.*$gdb_prompt $" {
+	pass "run past gdb1435"
+    }
+    -re ".*$gdb_prompt $" {
+	fail "run past gdb1435"
+    }
+    timeout {
+	fail "run past gdb1435 (timeout)"
+    }
+}
 
 gdb_test "backtrace 10" \
 	"#1\[ \t]*$hex in gdb1435.*\r\n#2\[ \t\]*$hex in main.*" \


  reply	other threads:[~2003-11-23 20:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-23 19:37 Mark Kettenis
2003-11-23 20:31 ` Daniel Jacobowitz
2003-11-23 20:51   ` Mark Kettenis [this message]
2003-11-23 20:57     ` Daniel Jacobowitz
2003-11-23 21:15       ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200311232050.hANKoRPN009597@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox