From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2813 invoked by alias); 21 Nov 2003 21:54:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2658 invoked from network); 21 Nov 2003 21:54:18 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 21 Nov 2003 21:54:18 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1ANJEI-000793-Fx; Fri, 21 Nov 2003 16:54:18 -0500 Date: Fri, 21 Nov 2003 21:54:00 -0000 From: Daniel Jacobowitz To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:symtab] deprecate inside_entry_func Message-ID: <20031121215418.GA27420@nevyn.them.org> Mail-Followup-To: Kevin Buettner , gdb-patches@sources.redhat.com References: <3FA2F940.5040102@redhat.com> <3FBE6D46.4070201@redhat.com> <20031121195949.GA794@nevyn.them.org> <3FBE79B6.2090209@redhat.com> <20031121204833.GA2356@nevyn.them.org> <3FBE7BD8.2090601@redhat.com> <20031121210412.GA2627@nevyn.them.org> <1031121212415.ZM17980@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1031121212415.ZM17980@localhost.localdomain> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00452.txt.bz2 On Fri, Nov 21, 2003 at 02:24:16PM -0700, Kevin Buettner wrote: > On Nov 21, 4:04pm, Daniel Jacobowitz wrote: > > > I imagine the third caller, in frv-tdep.c, is bogus > > and could be removed somehow. But if it's going to be left there then > > it seems reasonable to update it also. > > I had thought that get_prev_frame's call to inside_entry_func() had > been disabled pending a demonstration that it's needed. Hmm... I see > I was getting this confused with the code corresponding to > inside_entry_file(). > > Okay, that means that frv-tdep.c's use of inside_entry_func() can go > away. I'll get rid of it. Are you sure? /* NOTE: cagney/2003-07-15: Need to add a "set backtrace beyond-entry-func" command so that this can be selectively disabled. */ if (0 #if 0 && backtrace_beyond_entry_func #endif && this_frame->type != DUMMY_FRAME && this_frame->level >= 0 && inside_entry_func (get_frame_pc (this_frame))) -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer