From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25292 invoked by alias); 17 Nov 2003 18:39:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25284 invoked from network); 17 Nov 2003 18:39:10 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 17 Nov 2003 18:39:10 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1ALoHE-0003o9-5F; Mon, 17 Nov 2003 13:39:08 -0500 Date: Mon, 17 Nov 2003 18:39:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney , shebs@apple.com, jingham@apple.com, jmolenda@apple.com Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:symtab] Delete broken "memory mapped objfile cache" Message-ID: <20031117183908.GA5854@nevyn.them.org> Mail-Followup-To: Andrew Cagney , shebs@apple.com, jingham@apple.com, jmolenda@apple.com, gdb-patches@sources.redhat.com References: <3FA7D202.2050205@redhat.com> <3FB91529.8010005@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FB91529.8010005@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00359.txt.bz2 On Mon, Nov 17, 2003 at 01:36:25PM -0500, Andrew Cagney wrote: > > > >2003-11-02 Andrew Cagney > > > > * top.h (mapped_symbol_files): Delete declaration. > > * main.c (captured_main): Delete option "m" and "mapped". > > * objfiles.c (mapped_symbol_files): Delete variable. > > * symfile.c (symbol_file_command): Delete mmap code. > > (symbol_file_add_with_addrs_or_offsets): Ditto. > > (add_symbol_file_command, reread_separate_symbols): Ditto. > > * objfiles.h (OBJF_MAPPED): Delete. > > * objfiles.c (allocate_objfile) [USE_MMALLOC]: Delete. > > (free_objfile) [USE_MMALLOC]: Ditto. > > (open_existing_mapped_file): Delete function. > > (open_mapped_file): Delete function. > > (map_to_file): Delete function. > > > > Ping. I would prefer to have a comment from one of the Apple developers first. Is the code that Andrew removes substantially unchanged in your tree, where this feature works, or is it rewritten? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer