From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1048 invoked by alias); 11 Nov 2003 17:06:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1041 invoked from network); 11 Nov 2003 17:06:09 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 11 Nov 2003 17:06:09 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AJbxw-0004zO-Nv; Tue, 11 Nov 2003 12:06:08 -0500 Date: Tue, 11 Nov 2003 17:06:00 -0000 From: Daniel Jacobowitz To: Nick Clifton Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Fix shreloc.exp test driver to pass additional flags when linking Message-ID: <20031111170608.GA15680@nevyn.them.org> Mail-Followup-To: Nick Clifton , gdb-patches@sources.redhat.com References: <20031107143153.GA26353@nevyn.them.org> <20031107164045.GA32117@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00216.txt.bz2 On Mon, Nov 10, 2003 at 01:08:01PM +0000, Nick Clifton wrote: > Hi Guys, > > > Daniel Jacobowitz writes: > > >> On Fri, Nov 07, 2003 at 04:36:50PM +0000, Nick Clifton wrote: > >> > >> > An arm-elf toolchain doesn't have shared library support, does it? > >> > Then the test should probably be disabled. > >> > >> Is there an official way to do this. I could create a new dejagnu > >> variable along the lines of: > >> > >> set_board_info gdb,no_shared_libs 1 > >> > >> and then this could be tested in shreloc.exp ? > > > > There's no particular way to do it - that would work or just > > disabling the test for [istarget *-elf] || [istarget *-coff] would > > work too. > > Well that is certainly simpler. In which case, please may I have > approval to check in this patch ? This is fine, thank you! > > Cheers > Nick > > gdb/testsuite/ChangeLog > 2003-11-10 Nick Clifton > > * gdb.base/shreloc.exp: Do not run for targets which do not > support shared objects. > > Index: gdb/testsuite/gdb.base/shreloc.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/shreloc.exp,v > retrieving revision 1.1 > diff -c -3 -p -r1.1 shreloc.exp > *** gdb/testsuite/gdb.base/shreloc.exp 9 Jun 2003 21:23:53 -0000 1.1 > --- gdb/testsuite/gdb.base/shreloc.exp 10 Nov 2003 13:05:18 -0000 > *************** > *** 23,28 **** > --- 23,33 ---- > # them gets relocated at load-time. Check that gdb gets the right > # values for the debugging and minimal symbols. > > + if {[istarget *-elf*] || [istarget *-coff] || [istarget *-aout]} then { > + verbose "test skipped - shared object files not supported by this target." > + return 0 > + } > + > if $tracelevel then { > strace $tracelevel > } > > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer