From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23083 invoked by alias); 10 Nov 2003 16:26:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23076 invoked from network); 10 Nov 2003 16:26:45 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 10 Nov 2003 16:26:45 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AJEsG-0007Qi-JI for ; Mon, 10 Nov 2003 11:26:44 -0500 Date: Mon, 10 Nov 2003 16:26:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [commit] New function gdbarch_infi_fill Message-ID: <20031110162644.GA28489@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3FAED2DE.5000904@gnu.org> <20031110004823.GA7416@nevyn.them.org> <3FAFBA79.9060102@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FAFBA79.9060102@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00191.txt.bz2 On Mon, Nov 10, 2003 at 11:19:05AM -0500, Andrew Cagney wrote: > >On Sun, Nov 09, 2003 at 06:50:54PM -0500, Andrew Cagney wrote: > > > >>Hello, > >> > >>The attached adds the new function gdbarch_info_fill. This new function > >>fills in un-initialized fields of the "info" structure using global > >>"set" variables and the "gdbarch" parameter. > >> > >>committed, > >>Andrew > > > > > >Yeah! I've wanted this before. Though now I can't remember why. > > This all begs two questions. > > Should gdbarch_info be filled in first? Not sure. > Should the assertion: > > gdbarch_find_by_info (gdbarch_info (gdbarch)) == gdbarch > > always hold? At present architectures like the MIPS make this very hard > - keying off information found in the BFD and not the corresponding > info struct. This, however, I'd really like. I remember why I wanted it now. Take a look at the end of osabi.c:set_osabi - I am not especially confident that that code works. It seems to me that the above assertion makes it much more likely to work. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer