From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-28467-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 5998 invoked by alias); 7 Nov 2003 20:19:54 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 5978 invoked from network); 7 Nov 2003 20:19:53 -0000
Received: from unknown (HELO concert.shout.net) (204.253.184.25)
  by sources.redhat.com with SMTP; 7 Nov 2003 20:19:53 -0000
Received: from duracef.shout.net (duracef.shout.net [204.253.184.12])
	by concert.shout.net (8.12.10/8.12.10) with ESMTP id hA7KJpXw014222;
	Fri, 7 Nov 2003 14:19:51 -0600
Received: from duracef.shout.net (localhost [127.0.0.1])
	by duracef.shout.net (8.12.10/8.12.9) with ESMTP id hA7KJpfa024883;
	Fri, 7 Nov 2003 14:19:51 -0600
Received: (from mec@localhost)
	by duracef.shout.net (8.12.10/8.12.9/Submit) id hA7KJodd024882;
	Fri, 7 Nov 2003 15:19:50 -0500
Date: Fri, 07 Nov 2003 20:19:00 -0000
From: Michael Elizabeth Chastain <mec@shout.net>
Message-Id: <200311072019.hA7KJodd024882@duracef.shout.net>
To: ezannoni@redhat.com
Subject: Re: [rfc] msymbol.size
Cc: gdb-patches@sources.redhat.com
X-SW-Source: 2003-11/txt/msg00127.txt.bz2

eza> let me see if I can get at one.

The critical code is:

  /* dbxread.c */
  end_symtab (...)
  {
    ...
    if (pst->texthigh == 0 && last_function_name)
      {
      ...

      if (minsym)
	pst->texthigh = SYMBOL_VALUE_ADDRESS (minsym) + MSYMBOL_SIZE (minsym);

      ...
      }
    ...
  }

If that assignment executes, and the address and size have the same
value before and after my patch, then the patch is okay.

A before-and-after test run on such a platform would be perfect.

Michael C