Re: RFA: give store.exp tests unique names

[Michael Elizabeth Chastain <mec@shout.net>]

> Doesn't Michael C.'s system detect duplicate test names?
> Perhaps I am doing something wrong.

When my Crunch.pl sees a duplicate, it just renames the duplicate
to "gdb.foo/bar {2}", and then "gdb.foo/bar {3}", and so on.
Crunch.pl prints a count of duplicates on stdout but I don't
even pay attention to that any more.

Most of the duplicates are in tests that always PASS so it's
low priority to get them cleaned up.  Did this one in store.exp
cause an actual problem?  If it did, I'm all for stomping on it.

No comments on your specific patch, I'm too tired.

Michael C

2003-11-05  Jim Blandy  <jimb@redhat.com>

	* gdb.base/store.exp: Make sure every test has a unique name.

Index: gdb/testsuite/gdb.base/store.exp
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/store.exp,v
retrieving revision 1.4
diff -c -r1.4 store.exp
*** gdb/testsuite/gdb.base/store.exp	14 Aug 2003 22:44:06 -0000	1.4
--- gdb/testsuite/gdb.base/store.exp	6 Nov 2003 04:47:03 -0000
***************
*** 61,69 ****
      gdb_test "next" "l = add_${t} .l, r.;" "next ${t}"
      gdb_test "print l" " = ${l}" "print old l - ${t}"
      gdb_test "print r" " = ${r}" "print old r - ${t}"
!     gdb_test "set variable l = 4"
      gdb_test "print l" " = ${new}" "print new l - ${t}"
!     gdb_test "next" "return l \\+ r;"
      gdb_test "print l" " = ${add}" "print add  - ${t}"
  }
  
--- 61,69 ----
      gdb_test "next" "l = add_${t} .l, r.;" "next ${t}"
      gdb_test "print l" " = ${l}" "print old l - ${t}"
      gdb_test "print r" " = ${r}" "print old r - ${t}"
!     gdb_test "set variable l = 4" "" "set l - ${t}"
      gdb_test "print l" " = ${new}" "print new l - ${t}"
!     gdb_test "next" "return l \\+ r;" "next over call - ${t}"
      gdb_test "print l" " = ${add}" "print add  - ${t}"
  }
  
***************
*** 85,91 ****
      gdb_test "up" "l = add_${t} .l, r.;" "up ${t}"
      gdb_test "print l" " = ${l}" "up print old l - ${t}"
      gdb_test "print r" " = ${r}" "up print old r - ${t}"
!     gdb_test "set variable l = 4"
      gdb_test "print l" " = ${new}" "up print new l - ${t}"
  }
  
--- 85,91 ----
      gdb_test "up" "l = add_${t} .l, r.;" "up ${t}"
      gdb_test "print l" " = ${l}" "up print old l - ${t}"
      gdb_test "print r" " = ${r}" "up print old r - ${t}"
!     gdb_test "set variable l = 4" "" "up set l - ${t}"
      gdb_test "print l" " = ${new}" "up print new l - ${t}"
  }
  
***************
*** 105,113 ****
      gdb_test "tbreak wack_struct_${t}"
      gdb_test "continue" "int i; register struct s_${t} u = z_${t};" \
  	    "continue set struct ${t}"
!     gdb_test "next 2" "add_struct_${t} .u.;"
      gdb_test "print u" " = ${old}" "old check struct ${t}"
!     gdb_test "set variable u = s_${t}"
      gdb_test "print u" " = ${new}" "new check struct ${t}"
  }
  
--- 105,113 ----
      gdb_test "tbreak wack_struct_${t}"
      gdb_test "continue" "int i; register struct s_${t} u = z_${t};" \
  	    "continue set struct ${t}"
!     gdb_test "next 2" "add_struct_${t} .u.;" "check struct next ${t}"
      gdb_test "print u" " = ${old}" "old check struct ${t}"
!     gdb_test "set variable u = s_${t}" "" "set check struct ${t}"
      gdb_test "print u" " = ${new}" "new check struct ${t}"
  }
  
***************
*** 123,129 ****
  	    "continue up struct ${t}"
      gdb_test "up" "u = add_struct_${t} .u.;" "up struct ${t}"
      gdb_test "print u" " = ${old}" "old up struct ${t}"
!     gdb_test "set variable u = s_${t}"
      gdb_test "print u" " = ${new}" "new up struct ${t}"
  }
  
--- 123,129 ----
  	    "continue up struct ${t}"
      gdb_test "up" "u = add_struct_${t} .u.;" "up struct ${t}"
      gdb_test "print u" " = ${old}" "old up struct ${t}"
!     gdb_test "set variable u = s_${t}" "" "set up struct ${t}"
      gdb_test "print u" " = ${new}" "new up struct ${t}"
  }