From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9961 invoked by alias); 27 Oct 2003 20:53:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9953 invoked from network); 27 Oct 2003 20:53:28 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 27 Oct 2003 20:53:28 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id h9RKr1qK000305; Mon, 27 Oct 2003 21:53:01 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id h9RKqvnI000603; Mon, 27 Oct 2003 21:52:57 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id h9RKqq95000600; Mon, 27 Oct 2003 21:52:52 +0100 (CET) Date: Mon, 27 Oct 2003 20:53:00 -0000 Message-Id: <200310272052.h9RKqq95000600@elgar.kettenis.dyndns.org> From: Mark Kettenis To: ac131313@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <3F9D3E7F.2010001@redhat.com> (message from Andrew Cagney on Mon, 27 Oct 2003 10:49:19 -0500) Subject: Re: [PATCH/RFA] Re: [RFC] Core files and the architecture vector References: <200310112207.h9BM7WW0010332@elgar.kettenis.dyndns.org> <3F888D0E.4010001@redhat.com> <200310241504.h9OF4G6Q001663@elgar.kettenis.dyndns.org> <3F9D3E7F.2010001@redhat.com> X-SW-Source: 2003-10/txt/msg00797.txt.bz2 Date: Mon, 27 Oct 2003 10:49:19 -0500 From: Andrew Cagney Like it. Yep. Thanks, I checked it in, with a ChangeLog that also mentions the change to arch-utils.h: Index: ChangeLog from Mark Kettenis * arch-utils.c (deprecated_select_gdbarch_hack): New function. (gdbarch_from_bfd): New function. (set_gdbarch_from_file): Re-implement using gdbarch_from_bfd and deprecated_select_gdbarch_hack. * arch-utils.h (gdbarch_from_bfd): New prototype. BTW, while you're there can you tweak: error ("Architecture of file not recognized.\n"); to something like this: error ("Architecture %s of file not recognized", bfd_get_arch_info(bfd)->printable_name); Hmm, that would seem strange to me: Architecture sparc:v8plus of file not recognized Quite contradictory isn't it. By printing the name GDB implies that it is somehow recognizing the architecture. So I left this out for now. Perhaps we can change the string to something that doesn't let GDB make a fool out of itself? Mark