From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] target_open (target, ...)
Date: Thu, 23 Oct 2003 03:04:00 -0000 [thread overview]
Message-ID: <20031023030447.GA3517@nevyn.them.org> (raw)
In-Reply-To: <3F97431D.3040500@redhat.com>
On Wed, Oct 22, 2003 at 10:55:25PM -0400, Andrew Cagney wrote:
>
> >Wrong patch? This is target_close, not target_open. It also deletes
> >the target_open macro without adding a new target_open function.
>
> No, a 180 description. s/target_open/target_close/. The _macro_
> target_open() is _never_ called.
Gotcha.
> >Please don't add 'x'. There's nothing wrong with having a target_open
> >function which calls target_ops->to_open.
>
> The vector already contains ->to_open and ->to_close methods so unless
> we've switched to C++, I can't add a second to_close.
>
> Once the existing ->to_close is deprecated, I can rename ->to_xclose.
OK. It'd be nice if you'd explain that sort of thing when posting the
patch, though.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2003-10-23 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-22 21:38 Andrew Cagney
2003-10-23 2:36 ` Daniel Jacobowitz
2003-10-23 2:55 ` Andrew Cagney
2003-10-23 3:04 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031023030447.GA3517@nevyn.them.org \
--to=drow@mvista.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox