From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29460 invoked by alias); 23 Oct 2003 02:36:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29440 invoked from network); 23 Oct 2003 02:36:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 23 Oct 2003 02:36:07 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1ACVKZ-0000hQ-Io for ; Wed, 22 Oct 2003 22:36:07 -0400 Date: Thu, 23 Oct 2003 02:36:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [commit] target_open (target, ...) Message-ID: <20031023023607.GA2637@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3F96F8E6.5000702@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F96F8E6.5000702@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-10/txt/msg00677.txt.bz2 On Wed, Oct 22, 2003 at 05:38:46PM -0400, Andrew Cagney wrote: > Hello, > > This patch adds "struct target_ops" to target_open (now a function), and > a target vector method "to_xopen" that also takes a "struct target_ops". > > It then updates all the corresponding calls. > > committed, > Andrew > 2003-10-22 Andrew Cagney > > * target.c (target_close): New function. > (debug_to_close): Use "target_close". > (push_target): Use "target_close". > (unpush_target): Use "target_close". > (pop_target): Use "target_close". > * target.h (struct target_ops): Add "to_xclose". > (target_open): Delete macro. Move comment to "to_open". > (target_close): Replace macro with function that takes a target. > * top.c (quit_target): Pass "current_target" to "target_close". Wrong patch? This is target_close, not target_open. It also deletes the target_open macro without adding a new target_open function. Please don't add 'x'. There's nothing wrong with having a target_open function which calls target_ops->to_open. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer