Re: RFA/RFC: vCont for the remote protocol [client]

Andrew Cagney
2003-10-16T22:27:07Z

> There are two probems:
>>
>> - the buffer can get very very large and that can blow the stack
>> - it isn't possible to audit this code (with out a deep understanding of
>> that value) and hence demonstrate that the sprintf won't smash the
>> stack/heap
>>
>> You'll need to also change the sprintf to snprintf (parameterized with
>> remote_packet_size.
>
>
> I don't see a point in doing that until someone expresses interest in
> thread locking or some other feature which requires adding to the code.
> The maximum length of any generated vcont packet is the length of:
> vCont;C01:12341468;C02
> The minimum possible buffer size is about twenty times that.

I wrote "it isn't possible to audit this code (with out a deep
understanding of that [remote_packet_size] value)". The code should be
locally robust.

Andrew