From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9669 invoked by alias); 16 Oct 2003 13:11:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9660 invoked from network); 16 Oct 2003 13:11:45 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 16 Oct 2003 13:11:45 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AA7uq-0003ls-Vl for ; Thu, 16 Oct 2003 09:11:44 -0400 Date: Thu, 16 Oct 2003 13:11:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: RFA: Breakpoint infrastructure cleanups [0/8] Message-ID: <20031016131144.GA14202@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3F846B04.2070801@redhat.com> <3F85B4AC.7000000@redhat.com> <20031014013831.GB6118@nevyn.them.org> <3F8C18DD.3020508@redhat.com> <20031014155126.GA10669@nevyn.them.org> <3F8C605E.1060604@redhat.com> <3F8D6181.6070409@redhat.com> <3F8D8FEB.8020305@redhat.com> <16269.39677.813094.890124@localhost.redhat.com> <2719-Thu16Oct2003085405+0200-eliz@elta.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2719-Thu16Oct2003085405+0200-eliz@elta.co.il> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-10/txt/msg00537.txt.bz2 On Thu, Oct 16, 2003 at 08:54:05AM +0200, Eli Zaretskii wrote: > > From: Elena Zannoni > > Date: Wed, 15 Oct 2003 15:07:41 -0400 > > > > 1. insert the breakpoint, show confirmation to the user. If we have 20 > > 'real' breakpoints inserted, what do we tell the user? > > If we can guess the one address which is what the user wants to see in > the current context, let's show that single address. Otherwise, let's > either show all of them or none at all, perhaps controlled by some > user option. Seems reasonable. > > 2. hit the breakpoint, show line info about where we stopped, and > > breakpoint number. Do we just say the program hit the high level > > breakpoint number, or also which low level breakpoint number? > > I'd say we show the high-level number and the precise machine address > where it breaks. Right now we show the breakpoint address for breakpoints which are not at the beginning of a source line, and just the breakpoint and line numbers for breakpoints which are at the beginning of a line. How would this interact with that? Show the address always, or for breakpoints which either are in the middle of a line or in multiple locations? > > Hmm, do low level breakpoints have numbers? > > I don't think we need numbers for them, so let's not have them. I actually think that we do need numbers for them. My hypothetical use case is something like this: (gdb) break inline_foo Breakpoint 5 set at inline_foo, which has multiple locations. Say "info breakpoint 5" for more details. (gdb) info break 5 Num Type Enb Address What 1 sw breakpoint y 0x8040222 inlined into foo 2 sw breakpoint y 0x8040822 inlined into bar 3 sw breakpoint y 0x8040852 inlined into boring_loop (gdb) disable 5.3 (gdb) run I am not sure about "delete 5.3", though - that makes tracking which breakpoints have been set a little trickier, for not much gain. > > And MI? what should we do there? the same 3 cases occur. I would > > think that MI could just tell the gui everything every time, and then > > the GUI could decide to display what it wants. > > Probably. > > > However that's a lot > > of information sent back and forth, maybe for no real advantage. So > > maybe a two-tier command set is needed there too. > > Yes, probably. These make sense to me also. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer