From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15608 invoked by alias); 15 Oct 2003 22:32:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15595 invoked from network); 15 Oct 2003 22:32:58 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 15 Oct 2003 22:32:58 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1A9uCP-0008HN-9H for ; Wed, 15 Oct 2003 18:32:57 -0400 Date: Wed, 15 Oct 2003 22:32:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] target read/write partial Message-ID: <20031015223255.GA17644@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3F8DC73C.4090205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F8DC73C.4090205@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-10/txt/msg00515.txt.bz2 On Wed, Oct 15, 2003 at 06:16:28PM -0400, Andrew Cagney wrote: > Hello, > > This patch adds target read/write partial methods. > > It's almost ready for prime time. I want to first see through some > other target cleanups namely: > + /* FIXME: cagney/2003-10-15: This code should walk down the target > + stack looking for a stratum that supports the mechanism. > + Unfortunatly, there isn't a per-target-stack chain to walk round. > + Catch-22. */ > and a s/target_ops/target/ transformation. Preferably not target - didn't someone suggest gdbtarg? Or maybe gdb_target. > > Note that it includes: > + /* Transfer up-to LEN bytes of memory starting at OFFSET. */ > + TARGET_OBJECT_MEMORY > I'm going to need that when implementing a per-target > CONVERT_FROM_FUNC_PTR_ADDR. How is that different from a memory read, which we've already got? I am guessing that it's because you want to support partial memory operations (avoid packet size limits), but you never explained your goal. > + /* Map pre-existing objects onto letters. DO NOT do this for new > + objects!!! Instead specify new query packets. */ Could that be a little clearer - I had to read the code a couple of times to figure out what you meant. I guess you just want to say that there's no need to use single letters? > + /* Minimum outbuf size is (rs->remote_packet_size) - if bufsiz is > + not large enough let the caller. */ Missing a word there I think. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer