From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28335 invoked by alias); 15 Oct 2003 19:57:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28237 invoked from network); 15 Oct 2003 19:57:43 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 15 Oct 2003 19:57:43 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id h9FJvglW000291 for ; Wed, 15 Oct 2003 21:57:42 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id h9FJvfZ8000386 for ; Wed, 15 Oct 2003 21:57:41 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id h9FJvfwc000383; Wed, 15 Oct 2003 21:57:41 +0200 (CEST) Date: Wed, 15 Oct 2003 19:57:00 -0000 Message-Id: <200310151957.h9FJvfwc000383@elgar.kettenis.dyndns.org> From: Mark Kettenis To: gdb-patches@sources.redhat.com Subject: [PATCH/SPARC-branch] Make call dummies on non-executable stack work X-SW-Source: 2003-10/txt/msg00500.txt.bz2 The attached patch makes call dummies on a non-executable stack working. I checked this in on my SPARC branch. What do people think about checking this in on mainline? I don't thinkthis will get much exposure on the branch. Mark Index: ChangeLog from Mark Kettenis * infrun.c (handle_inferior_event): Allow for breakpoint instructions to generate a SIGSEGV in addition to SIGTRAP, SIGILL and SIGEMT. Update comments. Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.113 diff -u -p -r1.113 infrun.c --- infrun.c 14 Sep 2003 16:32:13 -0000 1.113 +++ infrun.c 15 Oct 2003 19:54:43 -0000 @@ -1845,16 +1845,21 @@ handle_inferior_event (struct execution_ will be made according to the signal handling tables. */ /* First, distinguish signals caused by the debugger from signals - that have to do with the program's own actions. - Note that breakpoint insns may cause SIGTRAP or SIGILL - or SIGEMT, depending on the operating system version. - Here we detect when a SIGILL or SIGEMT is really a breakpoint - and change it to SIGTRAP. */ + that have to do with the program's own actions. Note that + breakpoint insns may cause SIGTRAP or SIGILL or SIGEMT, depending + on the operating system version. Here we detect when a SIGILL or + SIGEMT is really a breakpoint and change it to SIGTRAP. We do + something similar for SIGSEGV, since a SIGSEGV will be generated + when we're trying to execute a breakpoint instruction on a + non-executable stack. This happens for call dummy breakpoints + for architectures like SPARC that place call dummies on the + stack. */ if (stop_signal == TARGET_SIGNAL_TRAP || (breakpoints_inserted && (stop_signal == TARGET_SIGNAL_ILL - || stop_signal == TARGET_SIGNAL_EMT)) + || stop_signal == TARGET_SIGNAL_EMT + || stop_signal == TARGET_SIGNAL_SEGV)) || stop_soon == STOP_QUIETLY || stop_soon == STOP_QUIETLY_NO_SIGSTOP) { @@ -1937,10 +1942,14 @@ handle_inferior_event (struct execution_ If someone ever tries to get get call dummys on a non-executable stack to work (where the target would stop - with something like a SIGSEG), then those tests might need to - be re-instated. Given, however, that the tests were only + with something like a SIGSEGV), then those tests might need + to be re-instated. Given, however, that the tests were only enabled when momentary breakpoints were not being used, I - suspect that it won't be the case. */ + suspect that it won't be the case. + + NOTE: kettenis/2003-10-15: Indeed such checks don't seem to + be necessary for call dummies on a non-executable stack on + SPARC. */ if (stop_signal == TARGET_SIGNAL_TRAP) ecs->random_signal