From: Michael Elizabeth Chastain <mec@shout.net>
To: ac131313@redhat.com, ezannoni@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] Deprecate msymbol.info, add msymbol.bfd_symbol?
Date: Tue, 14 Oct 2003 17:36:00 -0000 [thread overview]
Message-ID: <200310141736.h9EHal5r000665@duracef.shout.net> (raw)
eza> OK, so what you are really saying is that there are in the whole gdb
eza> only a few calls to {prim_}record_minimal_symbol_and_info which have
eza> a non-null info parameter (the 4th one).
Yes, that is true.
I think there are two things we could do to elfread.c:
(1A) Quit abusing msymbol.info to store a size in some of the bits.
Just create msymbol.size with the proper data type.
(1B) More like Elena says (and maybe Andrew is saying), change
the actual algorithm to use bfd information.
Perhaps (1A) would be a useful patch to separate out this issue
from the other uses of msymbol.info. We could do (1B) later.
Or just go straight to (1B).
Over in coffread.c, with the "cs->c_sclass" being stuffed into
msymbol.info, gdb 4.17 (!) used to read it back. But then that
changed with gdb 4.18. Again there are two ways to deal with this:
(2A) Data is being written and never read back anywhere, just
mechanically kill the write.
(2B) Data is being written and never read back anywhere, investigate
what *should* be happening (if anything). And it might turn out
that what *should* happen is the same code should die, after
someone puts some thought into it.
I have to say, I was a fan of (2A), but now I am not, because if
we just do (2A), then we have nothing to remind us of (2B) later.
eza> Then there are MSYMBOL_IS_SPECIAL, msymbol_is_special, MSYMBOL_IS_RTC,
eza> MSYMBOL_IS_RTI. All of them can just use the bfd symbol instead, and
eza> are only in the tdep files.
Yeah.
eza> So, ok. Makes sense.
Sounds like everybody is converging on a common vision. Yay.
Michael C
next reply other threads:[~2003-10-14 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-14 17:36 Michael Elizabeth Chastain [this message]
2003-10-14 20:09 ` Elena Zannoni
-- strict thread matches above, loose matches on Subject: below --
2003-10-11 20:44 Michael Elizabeth Chastain
2003-10-11 20:22 Michael Elizabeth Chastain
2003-10-11 20:42 ` Andrew Cagney
2003-10-11 18:39 Michael Elizabeth Chastain
2003-10-11 20:02 ` Andrew Cagney
2003-10-13 20:28 ` Elena Zannoni
2003-10-11 17:16 Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310141736.h9EHal5r000665@duracef.shout.net \
--to=mec@shout.net \
--cc=ac131313@redhat.com \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox