From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18339 invoked by alias); 13 Oct 2003 09:14:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18332 invoked from network); 13 Oct 2003 09:14:08 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 13 Oct 2003 09:14:08 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9D9E7M21782 for ; Mon, 13 Oct 2003 05:14:07 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9D9E6L27993 for ; Mon, 13 Oct 2003 05:14:07 -0400 Received: from cygbert.vinschen.de (vpn50-5.rdu.redhat.com [172.16.50.5]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h9D9E5J11853 for ; Mon, 13 Oct 2003 02:14:05 -0700 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 1A19358048; Mon, 13 Oct 2003 11:14:04 +0200 (CEST) Date: Mon, 13 Oct 2003 09:14:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] gdb.base/call-rt-st.*: Add char bitfield and short bitfield tests Message-ID: <20031013091403.GK14344@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <200310112126.h9BLQHa1022798@duracef.shout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200310112126.h9BLQHa1022798@duracef.shout.net> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-10/txt/msg00422.txt.bz2 On Sat, Oct 11, 2003 at 05:26:17PM -0400, Michael Elizabeth Chastain wrote: > I proofread the patch and found one copy-and-paste glitch: > > if ![gdb_skip_stdio_test "print print_bit_flags_short(*flags)"] { > print_struct_call "print_bit_flags(*flags)" \ > ".*alpha\[ \r\n\]+gamma\[ \r\n\]+epsilon\[ \r\n\]+.\[0-9\]+ = \\{alpha = 1, beta = 0, gamma = 1, delta = 0, epsilon = 1, omega = 0\\}" > } > > The second line should be "print_struct_call print_bit_flags_short". > > My test bed likes this patch. > > Recommended for approval, with this change. Changed and applied. Thanks, Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc.