From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1039 invoked by alias); 10 Oct 2003 19:22:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1021 invoked from network); 10 Oct 2003 19:22:57 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Oct 2003 19:22:57 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9AJMuM11906 for ; Fri, 10 Oct 2003 15:22:56 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9AJMtD09973 for ; Fri, 10 Oct 2003 15:22:56 -0400 Received: from cygbert.vinschen.de (vpn50-15.rdu.redhat.com [172.16.50.15]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h9AJMsi29791 for ; Fri, 10 Oct 2003 12:22:54 -0700 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 02D5C58046; Fri, 10 Oct 2003 21:22:52 +0200 (CEST) Date: Fri, 10 Oct 2003 19:22:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] sh-tdep.c: Fix float handling Message-ID: <20031010192252.GQ14344@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20031004121102.GL11435@cygbert.vinschen.de> <16263.30.584298.427986@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16263.30.584298.427986@localhost.redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-10/txt/msg00371.txt.bz2 On Fri, Oct 10, 2003 at 02:53:18PM -0400, Elena Zannoni wrote: > Please add this expanation as a comment. I find cleared than your > shorter comments. Just add it before the helper function. > > >From here.... > > > First, in contrast to non-FPU CPUs, arguments are never split between > > registers and stack. If an argument doesn't fit in the remaining registers > > it's always pushed entirely on the stack. My testing led me to the wrong > > assumption that just types > 16 bytes are pushed entirely on the stack. I have a problem with this first part of the comment. This one does not fit well as a comment to the helper function. I would suggest to add this (carefully rephrased) to sh_push_dummy_call_fpu(), substituting the very short /* No data is passed partially in registers. */ comment instead. Ok? > Since this is a predicate, can you call it sh_treat_as_flt_p . Ok. > Ok otherwise. Thanks, I'd just like to hear about the above comment. > BTW, what multilibs are you testing? Several, -m2, -m2e, m3e, m4, m4 -ml, -m4-single. Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc.