Re: [RFA] sh-tdep.c (sh_use_struct_convention): Restructure and fix

Kevin Buettner
2003-10-04T17:04:40Z

On Oct 4, 11:54am, Andrew Cagney wrote:

> See: http://sources.redhat.com/ml/gdb-patches/2003-10/msg00033.html.
> The ppc64_sysv_return_value code in ppc-sysv-tdep.c, has been written in
> a way that allows a quick update to this new iterface.

Andrew,

There are pros and cons to the approach that you used in
ppc64_sysv_abi_return_value().

On the pro side - and this is definitely a good thing - you keep the
struct convention information together with the implementation of how
to return a value.

But this is also a con because you've spread the definition of
"use_struct_convention" out over a much larger number of lines. It
isn't (IMO) as easy to comprehend when arranged in this way.

The jury is still out (at least as far as I'm concerned) as to
which approach is better. I do happen to think that your approach
is better for ppc64 (and ppc too), but this may not necessarily be the
case for other architectures.

With regard to Corinna's patch, she's fixed some bugs and has improved
readability. If Corinna looks at your approach and finds it
compelling enough to redo her patch, that's fine. But I don't think
there should be an (implied) requirement that she do so.

Kevin