From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26453 invoked by alias); 8 Oct 2003 01:05:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26445 invoked from network); 8 Oct 2003 01:05:10 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 8 Oct 2003 01:05:10 -0000 Received: from drow by nevyn.them.org with local (Exim 4.22 #1 (Debian)) id 1A72lK-00045k-5D for ; Tue, 07 Oct 2003 21:05:10 -0400 Date: Wed, 08 Oct 2003 01:05:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: RFC: Use program_transform_name correctly Message-ID: <20031008010510.GA15693@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20031007225305.GA13082@nevyn.them.org> <20031007235921.8FB0B158F81@kanga.canids.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031007235921.8FB0B158F81@kanga.canids.net> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-10/txt/msg00195.txt.bz2 On Tue, Oct 07, 2003 at 04:59:21PM -0700, Felix Lee wrote: > Daniel Jacobowitz : > > Eh, you're right, this will teach me to answer without looking. From > > gcc/Makefile.in: > > t='$(program_transform_cross_name)'; echo ar | sed -e $$t ; \ > > That's the idiom we should use here. > > yeah, $$t should be unquoted because configure does the quoting, > so that a transformation that has quotes will work correctly. > however, this is only for "recent" versions of autoconf, where > recent is "some version of autoconf after 2.13 that still says > 'generated by 2.13' at the top of configure". > > autoconf 2.13 and before will sometimes leave > program_transform_name null, which will cause that sed to fail. How horrid. > the newer autoconfs will make sure program_transform_name is > 's,x,x,' if it would otherwise be null. Conveniently this is no longer an issue in the src repository (or in gcc). The toplevel configure script now guarantees that $(program_transform_name) will not be empty. So $$t it is. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer