From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1669 invoked by alias); 7 Oct 2003 02:47:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1662 invoked from network); 7 Oct 2003 02:47:02 -0000 Received: from unknown (HELO life.ai.mit.edu) (128.52.32.80) by sources.redhat.com with SMTP; 7 Oct 2003 02:47:02 -0000 Received: from perdition.linnaean.org (h00d0b75e7f36.ne.client2.attbi.com [66.31.46.104]) by life.ai.mit.edu (8.12.9/8.12.9/BASENAME(ai.master.life-8.12.9.mc,.mc):RCS_REVISION(Revision: 1.23)) with ESMTP id h972l0bg002177; Mon, 6 Oct 2003 22:47:01 -0400 (EDT) Received: by perdition.linnaean.org (Postfix, from userid 5281) id 80E921B9E4; Mon, 6 Oct 2003 22:47:00 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: unwind support for Linux 2.6 vsyscall DSO In-Reply-To: Roland McGrath's message of Monday, 6 October 2003 19:40:11 -0700 <200310070240.h972eBoX011939@magilla.sf.frob.com> Emacs: the only text editor known to get indigestion. Message-Id: <20031007024700.80E921B9E4@perdition.linnaean.org> Date: Tue, 07 Oct 2003 02:47:00 -0000 X-SW-Source: 2003-10/txt/msg00155.txt.bz2 > I understand. I would prefer a block-reading interface in the target > vector (e.g. something similar to target_read_aux_vector as in the patch I > posted) and a utility function that is an iterator applied to the block. Note one reason I prefer this is that the utility function is needed regardless. If the to_read_aux_vector hook is an iterator, then each implementation will use this utility function on the contents it's read in. If the to_read_aux_vector hook returns the whole block, then some of the callers (not those doing core file writing) will use this utility function on the contents supplied by the target hook. The code that needs to be shared (or duplicated) is the same either way.