From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15671 invoked by alias); 6 Oct 2003 16:51:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15662 invoked from network); 6 Oct 2003 16:51:28 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 6 Oct 2003 16:51:28 -0000 Received: from drow by nevyn.them.org with local (Exim 4.22 #1 (Debian)) id 1A6YZy-0005eS-F1; Mon, 06 Oct 2003 12:51:26 -0400 Date: Mon, 06 Oct 2003 16:51:00 -0000 From: Daniel Jacobowitz To: David Carlton Cc: David Lecomber , gdb-patches@sources.redhat.com Subject: Re: Large array printing patch for Fortran Message-ID: <20031006165125.GA21526@nevyn.them.org> Mail-Followup-To: David Carlton , David Lecomber , gdb-patches@sources.redhat.com References: <20030910143536.GA23943@streamline-computing.com> <20030915155834.GA8599@nevyn.them.org> <20030915195058.GA12113@streamline-computing.com> <20030929173517.GA12280@streamline-computing.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-10/txt/msg00106.txt.bz2 On Mon, Oct 06, 2003 at 09:45:45AM -0700, David Carlton wrote: > On Mon, 29 Sep 2003 18:35:17 +0100, David Lecomber said: > > > This patch sets the formatting correctly in the patch I previously > > applied. > > > 2003-09-29 David Lecomber > > > * f-valprint.c: Reformatting > > I'm sorry you find it frustrating that people don't approve your > patches as quickly as they should. But you still have to wait for > approval before committing them. I've told you this before, Daniel > has told you this before. If you don't like waiting, nag people; > don't just go ahead and commit stuff. > > There are two things wrong with your ChangeLog entry; I'm in a bad > enough mood that I'm not going to tell you what they are. Look > through other ChangeLog entries, see how yours is different from > theirs. (And, while you're at it, look at what's wrong with your > ChangeLog entry from 2003-09-15, too.) Then, post the diffs here and > WAIT FOR SOMEBODY TO GIVE YOU EXPLICIT APPROVAL TO COMMIT THEM. (A) I approved this patch in private. (B) It's an obvious, withspace only patch so I didn't feel the need to copy the list when I approved it. (C) As a write-after-approval maintainer he is allowed to commit truly obvious patches. Which this will be once he gets changelog style down. I'm sorry I didn't post the approval in triplicate to the list. David L, the problems David C refers to: - Generally include the names of modified functions, unless you're globally touching the whole file. - ChangeLog entries end with a full stop. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer