From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4797 invoked by alias); 4 Oct 2003 18:08:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4790 invoked from network); 4 Oct 2003 18:08:57 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 4 Oct 2003 18:08:57 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h94I8t109008 for ; Sat, 4 Oct 2003 14:08:56 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h94I8tD01686 for ; Sat, 4 Oct 2003 14:08:55 -0400 Received: from cygbert.vinschen.de (vpn50-13.rdu.redhat.com [172.16.50.13]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h94I8rw17006 for ; Sat, 4 Oct 2003 11:08:54 -0700 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 790AF58049; Sat, 4 Oct 2003 20:08:52 +0200 (CEST) Date: Sat, 04 Oct 2003 18:08:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] sh-tdep.c (sh_use_struct_convention): Restructure and fix Message-ID: <20031004180852.GA29063@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20031004113939.GK11435@cygbert.vinschen.de> <3F7EED21.1060902@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F7EED21.1060902@redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-10/txt/msg00086.txt.bz2 On Sat, Oct 04, 2003 at 11:54:09AM -0400, Andrew Cagney wrote: > > * sh-tdep.c (sh_use_struct_convention): Clean up to have a > > more readable code. Accomodate 4 byte structs with 4 byte sized > > first field (e.g. bitfields). > > Corinna, > > See: http://sources.redhat.com/ml/gdb-patches/2003-10/msg00033.html. > The ppc64_sysv_return_value code in ppc-sysv-tdep.c, has been written in > a way that allows a quick update to this new iterface. I think my patch is fine. I'm fixing non-deprecated functions to work better than before. There's nothing wrong with this and I don't see any gain to use an entirely new technique (2 days old!) to get probably new errors which I don't have using this method. Fixing the bugs is step 1. Converting them to a new technique is another, later step. Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc.