Re: [RFA] sh-tdep.c (sh_use_struct_convention): Restructure and fix

Corinna Vinschen
2003-10-04T18:08:57Z

On Sat, Oct 04, 2003 at 11:54:09AM -0400, Andrew Cagney wrote:
> > * sh-tdep.c (sh_use_struct_convention): Clean up to have a
> > more readable code. Accomodate 4 byte structs with 4 byte sized
> > first field (e.g. bitfields).
>
> Corinna,
>
> See: http://sources.redhat.com/ml/gdb-patches/2003-10/msg00033.html.
> The ppc64_sysv_return_value code in ppc-sysv-tdep.c, has been written in
> a way that allows a quick update to this new iterface.

I think my patch is fine. I'm fixing non-deprecated functions to
work better than before. There's nothing wrong with this and I
don't see any gain to use an entirely new technique (2 days old!)
to get probably new errors which I don't have using this method.

Fixing the bugs is step 1. Converting them to a new technique is
another, later step.

Corinna

--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.