From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25718 invoked by alias); 3 Oct 2003 08:09:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25708 invoked from network); 3 Oct 2003 08:09:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 3 Oct 2003 08:09:42 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9389f131338 for ; Fri, 3 Oct 2003 04:09:41 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9389eD29567 for ; Fri, 3 Oct 2003 04:09:40 -0400 Received: from cygbert.vinschen.de (vpn50-5.rdu.redhat.com [172.16.50.5]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h9389dw02171 for ; Fri, 3 Oct 2003 01:09:39 -0700 Received: by cygbert.vinschen.de (Postfix, from userid 500) id BE3B658044; Fri, 3 Oct 2003 10:09:37 +0200 (CEST) Date: Fri, 03 Oct 2003 08:09:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] dwarf2-frame.c: Support DW_EH_PE_textrel encoding Message-ID: <20031003080937.GA31760@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20031002200652.GX11435@cygbert.vinschen.de> <200310022210.h92MAYWe000796@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200310022210.h92MAYWe000796@elgar.kettenis.dyndns.org> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-10/txt/msg00046.txt.bz2 On Fri, Oct 03, 2003 at 12:10:34AM +0200, Mark Kettenis wrote: > I've got a problem with re-using the variable named `got' in > dwarf2_build_frame_info() for the ".text" section. Could you please > rename the variable to something more generic (for example `sect') or > introduce a new variable? > > I'd also appreciate it if you changed gcc into GCC in the comment > (thats the spelling the GCC project uses, and makes the sentence start > with a capital). You'll need to add an extra space after the . too. > > With those changes, this is OK. > > * dwarf2-frame.c (struct comp_unit): Add tbase member to store > base for DW_EH_PE_textrel encodings. > (read_encoded_value): Add a DW_EH_PE_textrel case. > (dwarf2_build_frame_info): Set unit.tbase to beginning of text > section. Applied with the suggested changes. I've introduced a new "txt" variable instead of reusing "got". Thanks, Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc.