From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8858 invoked by alias); 2 Oct 2003 22:10:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8845 invoked from network); 2 Oct 2003 22:10:36 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 2 Oct 2003 22:10:36 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id h92MAZbA000270 for ; Fri, 3 Oct 2003 00:10:35 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id h92MAYug000799 for ; Fri, 3 Oct 2003 00:10:34 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id h92MAYWe000796; Fri, 3 Oct 2003 00:10:34 +0200 (CEST) Date: Thu, 02 Oct 2003 22:10:00 -0000 Message-Id: <200310022210.h92MAYWe000796@elgar.kettenis.dyndns.org> From: Mark Kettenis To: gdb-patches@sources.redhat.com In-reply-to: <20031002200652.GX11435@cygbert.vinschen.de> (message from Corinna Vinschen on Thu, 2 Oct 2003 22:06:52 +0200) Subject: Re: [RFA] dwarf2-frame.c: Support DW_EH_PE_textrel encoding References: <20031002200652.GX11435@cygbert.vinschen.de> X-SW-Source: 2003-10/txt/msg00041.txt.bz2 Date: Thu, 2 Oct 2003 22:06:52 +0200 From: Corinna Vinschen Hi, I'm not sure if the patch is actually 100% correct but I think it's not far from that. It looks sensible to me. For a few weeks now, gcc emits the DW_EH_PE_textrel encoding for sh and (AFAICS) ia64. This encoding type is unsupported in gdb so far. The below patch tries to accomodate this encoding. Is the patch ok as it is? On sh, the testcases failing with a gcc emitting this encoding run through with the below patch and the overall FAIL count is the same as before. I've got a problem with re-using the variable named `got' in dwarf2_build_frame_info() for the ".text" section. Could you please rename the variable to something more generic (for example `sect') or introduce a new variable? I'd also appreciate it if you changed gcc into GCC in the comment (thats the spelling the GCC project uses, and makes the sentence start with a capital). You'll need to add an extra space after the . too. With those changes, this is OK. * dwarf2-frame.c (struct comp_unit): Add tbase member to store base for DW_EH_PE_textrel encodings. (read_encoded_value): Add a DW_EH_PE_textrel case. (dwarf2_build_frame_info): Set unit.tbase to beginning of text section.