Re: SH patch 2 (was Re: [RFA] SH: Deprecate deprecated functions, use new frame interface)

Corinna Vinschen
2003-09-22T15:08:42Z

On Mon, Sep 22, 2003 at 10:44:05AM -0400, Daniel Jacobowitz wrote:
> On Mon, Sep 22, 2003 at 04:32:54PM +0200, Corinna Vinschen wrote:
> > What does that mean? How does that affect the approval of my code
> > as it is now?
>
> I can't answer the second question, but I can answer the first.
>
> DW_OP_piece is not supported yet. Kevin B. put together a nice little
> patch for a strictly limited case of DW_OP_piece triggered by the
> PowerPC e500 port; I don't know if this SH occurance is similar or a
> more general usage.
>
> You may want to remove the bit which enables dwarf2 unwinding until
> this is fixed? Just a thought.

I don't think that's necessary. The results with dwarf2 unwinding are
1 FAIL less than without dwarf2 unwinding. Removing the dwarf2
unwinding might result in forgetting it. Keeping it in will remind us
that the dwarf2 unwinder still needs a bit of work.