From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3003 invoked by alias); 22 Sep 2003 14:44:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2920 invoked from network); 22 Sep 2003 14:44:06 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 22 Sep 2003 14:44:06 -0000 Received: from drow by nevyn.them.org with local (Exim 4.22 #1 (Debian)) id 1A1Rv3-0005Jh-Uf for ; Mon, 22 Sep 2003 10:44:05 -0400 Date: Mon, 22 Sep 2003 14:44:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: SH patch 2 (was Re: [RFA] SH: Deprecate deprecated functions, use new frame interface) Message-ID: <20030922144405.GA20343@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20030908165510.GK1859@cygbert.vinschen.de> <16226.1322.230352.450541@localhost.redhat.com> <20030915160111.GA9283@cygbert.vinschen.de> <16231.17730.828347.741094@localhost.redhat.com> <20030916172606.GU9981@cygbert.vinschen.de> <20030916173038.GA25459@nevyn.them.org> <20030922143254.GR9981@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030922143254.GR9981@cygbert.vinschen.de> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-09/txt/msg00462.txt.bz2 On Mon, Sep 22, 2003 at 04:32:54PM +0200, Corinna Vinschen wrote: > On Tue, Sep 16, 2003 at 01:30:38PM -0400, Daniel Jacobowitz wrote: > > On Tue, Sep 16, 2003 at 07:26:06PM +0200, Corinna Vinschen wrote: > > > FAIL: gdb.base/store.exp: print add - charest > > > FAIL: gdb.base/store.exp: print add - short > > > FAIL: gdb.base/store.exp: print old r - longest > > > FAIL: gdb.base/store.exp: print old r - double > > > FAIL: gdb.base/store.exp: print old r - doublest > > > FAIL: gdb.base/store.exp: up print old r - longest > > > FAIL: gdb.base/store.exp: up print old r - double > > > FAIL: gdb.base/store.exp: up print old r - doublest > > > > Hmm, with the current state of the tree those failures are pretty > > surprising. Especially if you turned on the dwarf2 unwinder, they > > shouldn't be there. > > Hmm, I'm getting a bunch of "Unhandled dwarf expression opcode" > messages. The opcode in question is 0x93, DW_OP_piece. I tweaked > the error message in dwarf2expr.c::execute_stack_op() to print the > opcode as well, so what I get is e.g. this: > > [...] > continue^M > Continuing.^M > wack_longest (u=Unhandled dwarf expression opcode: 0x93^M > ) at /home/corinna/src/gdb/src/gdb/testsuite/gdb.base/store.c:101^M > 101 register longest l = u, r = v;^M > (gdb) PASS: gdb.base/store.exp: continue to wack_longest > next^M > 102 l = add_longest (l, r);^M > (gdb) PASS: gdb.base/store.exp: next longest > print l^M > $17 = -1^M > (gdb) PASS: gdb.base/store.exp: print old l - longest > print r^M > Unhandled dwarf expression opcode: 0x93^M > (gdb) FAIL: gdb.base/store.exp: print old r - longest > > What does that mean? How does that affect the approval of my code > as it is now? I can't answer the second question, but I can answer the first. DW_OP_piece is not supported yet. Kevin B. put together a nice little patch for a strictly limited case of DW_OP_piece triggered by the PowerPC e500 port; I don't know if this SH occurance is similar or a more general usage. You may want to remove the bit which enables dwarf2 unwinding until this is fixed? Just a thought. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer