Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fix hash table mixup in bfd_simple_get_relocated_section_content
Date: Wed, 17 Sep 2003 16:09:00 -0000	[thread overview]
Message-ID: <20030917160957.GA9588@nevyn.them.org> (raw)
In-Reply-To: <jeu17b1jwq.fsf@sykes.suse.de>

On Wed, Sep 17, 2003 at 06:04:05PM +0200, Andreas Schwab wrote:
> bfd_simple_get_relocated_section_content uses the generic linker
> interface, so it should also use the generic_link_hash_table.

Hmm, this seems right to me.

> 2003-09-17  Andreas Schwab  <schwab@suse.de>
> 
> 	* simple.c (bfd_simple_get_relocated_section_contents): Use
> 	_bfd_generic_link_hash_table_create instead of
> 	bfd_link_hash_table_create.
> 
> --- bfd/simple.c.~1.9.~	2003-06-05 16:07:52.000000000 +0200
> +++ bfd/simple.c	2003-09-17 17:32:49.000000000 +0200
> @@ -198,7 +198,7 @@ bfd_simple_get_relocated_section_content
>    memset (&link_info, 0, sizeof (link_info));
>    link_info.input_bfds = abfd;
>  
> -  link_info.hash = bfd_link_hash_table_create (abfd);
> +  link_info.hash = _bfd_generic_link_hash_table_create (abfd);
>    link_info.callbacks = &callbacks;
>    callbacks.warning = simple_dummy_warning;
>    callbacks.undefined_symbol = simple_dummy_undefined_symbol;
> 
> -- 
> Andreas Schwab, SuSE Labs, schwab@suse.de
> SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
> Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-09-17 16:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-17 16:04 Andreas Schwab
2003-09-17 16:09 ` Daniel Jacobowitz [this message]
2003-09-17 16:46   ` Andreas Schwab
2003-09-17 18:26     ` Andrew Cagney
2003-09-17 19:41       ` Andreas Schwab
2003-09-17 20:42         ` Andrew Cagney
2003-09-18  1:57           ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030917160957.GA9588@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox