From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5320 invoked by alias); 16 Sep 2003 15:57:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5313 invoked from network); 16 Sep 2003 15:57:07 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 16 Sep 2003 15:57:07 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h8GFv6426793 for ; Tue, 16 Sep 2003 11:57:06 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h8GFuxL30797 for ; Tue, 16 Sep 2003 11:57:05 -0400 Received: from cygbert.vinschen.de (vpn50-35.rdu.redhat.com [172.16.50.35]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h8GFuww18350 for ; Tue, 16 Sep 2003 08:56:58 -0700 Received: by cygbert.vinschen.de (Postfix, from userid 500) id B1C545839D; Tue, 16 Sep 2003 17:56:54 +0200 (CEST) Date: Tue, 16 Sep 2003 15:57:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: SH patch 1 (was Re: [RFA] SH: Deprecate deprecated functions, use new frame interface) Message-ID: <20030916155654.GT9981@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20030908165510.GK1859@cygbert.vinschen.de> <16226.1322.230352.450541@localhost.redhat.com> <20030915155259.GG9981@cygbert.vinschen.de> <16231.7524.778391.339845@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16231.7524.778391.339845@localhost.redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-09/txt/msg00357.txt.bz2 On Tue, Sep 16, 2003 at 10:25:40AM -0400, Elena Zannoni wrote: > Corinna Vinschen writes: > > On Fri, Sep 12, 2003 at 01:40:58PM -0400, Elena Zannoni wrote: > > > Seems ok, but....could you split the renaming of insn to inst and > > > removal of tdep into a separate patch, and repost the 2 patches? > > > I.e. the renaming/tdep and the real cleanups after that. It's not easy > > > to see what's going on with this diff. > > > > > > thanks > > > elena > > > > Ok, this is the first patch which consists entirely of pure > > mechanical changes... > > > > Ah, much easier. Thanks, yes. Thanks, I've applied this first part of the patch. Corinna > > * sh-tdep.h (struct gdbarch_tdep): Remove. Change all register > > numbers to enumeration values. > > * sh-tdep.c: Accomodate above change. > > (SH_NUM_REGS): Rename from SH_DEFAULT_NUM_REGS. > > (NUM_PSEUDO_REGS_SH_MEDIA): Remove (sh5 only). > > (NUM_PSEUDO_REGS_SH_COMPACT): Remove (sh5 only). > > (IS_ADD_IMM_SP): Rename from IS_ADD_SP. > > (IS_FPUSH): Rename from IS_FMOV. > > (sh_extract_struct_value_address): Remove useless comment. > > (sh_dsp_register_sim_regno): Use register values from sh-tdep.h > > instead of own local values. > > (sh_dump_tdep): Remove. > > (_initialize_sh_tdep): Accomodate removing sh_dump_tdep. > > * sh3-rom.c (sh3_supply_register): Accomodate sh-tdep.h changes. -- Corinna Vinschen Cygwin Developer Red Hat, Inc.