From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24923 invoked by alias); 15 Sep 2003 21:52:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24766 invoked from network); 15 Sep 2003 21:52:38 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 15 Sep 2003 21:52:38 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h8FLqV8P000493; Mon, 15 Sep 2003 23:52:31 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h8FLqVco007569; Mon, 15 Sep 2003 23:52:31 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h8FLqUqN007566; Mon, 15 Sep 2003 23:52:30 +0200 (CEST) Date: Mon, 15 Sep 2003 21:52:00 -0000 Message-Id: <200309152152.h8FLqUqN007566@elgar.kettenis.dyndns.org> From: Mark Kettenis To: drow@mvista.com CC: gdb-patches@sources.redhat.com, binutils@sources.redhat.com, gcc-patches@gcc.gnu.org In-reply-to: <20030915143933.GA22129@nevyn.them.org> (message from Daniel Jacobowitz on Mon, 15 Sep 2003 10:39:33 -0400) Subject: Re: [libiberty and gdb] floatformat_is_valid References: <20030915143933.GA22129@nevyn.them.org> X-SW-Source: 2003-09/txt/msg00348.txt.bz2 Date: Mon, 15 Sep 2003 10:39:33 -0400 From: Daniel Jacobowitz 2003-09-15 Daniel Jacobowitz * floatformat.h (floatformat_is_valid): Add prototype. 2003-09-15 Daniel Jacobowitz * floatformat.c (floatformat_is_valid): New function. (get_field, put_field): Correct comments. 2003-09-15 Daniel Jacobowitz * values.c (unpack_double): Call floatformat_is_valid. There's a problem with cons-correctness :-(. gcc -c -g -O2 -I. -I../../src/gdb -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../intl -I../../src/gdb/../intl -DMI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Wformat-nonliteral -Werror ../../src/gdb/values.c cc1: warnings being treated as errors ../../src/gdb/values.c: In function `unpack_double': ../../src/gdb/values.c:744: warning: passing arg 2 of `floatformat_is_valid' discards qualifiers from pointer target type gmake[1]: *** [values.o] Error 1 gmake[1]: Leaving directory `/usr/home/kettenis/sandbox/gdb/obj/gdb' gmake: *** [all-gdb] Error 2 Could you fix that please? Mark