From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17764 invoked by alias); 13 Sep 2003 23:26:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17757 invoked from network); 13 Sep 2003 23:26:23 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 13 Sep 2003 23:26:23 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h8DNQEEf000652; Sun, 14 Sep 2003 01:26:14 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h8DNQEiA020840; Sun, 14 Sep 2003 01:26:14 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h8DNQDOw020837; Sun, 14 Sep 2003 01:26:13 +0200 (CEST) Date: Sat, 13 Sep 2003 23:26:00 -0000 Message-Id: <200309132326.h8DNQDOw020837@elgar.kettenis.dyndns.org> From: Mark Kettenis To: ac131313@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <3F63330B.4070209@redhat.com> (message from Andrew Cagney on Sat, 13 Sep 2003 11:08:59 -0400) Subject: Re: [PATCH] Deperectate REG_STRUCT_HAS_ADDR References: <200309131413.h8DEDFlB012278@elgar.kettenis.dyndns.org> <3F63330B.4070209@redhat.com> X-SW-Source: 2003-09/txt/msg00297.txt.bz2 Date: Sat, 13 Sep 2003 11:08:59 -0400 From: Andrew Cagney > Index: ChangeLog > from Mark Kettenis > > * gdbarch.sh (DEPRECATED_REG_STRUCT_HAS_ADDR): Renamed from > REG_STRUCT_HAS_ADDR. > * gdbarch.c, gdbarch.h: Updated. > * infcall.c (call_function_by_hand): Update. > * stabsread.c (define_symbol): Updated. > > Index: doc/ChangeLog > from Mark Kettenis > > * gdbint.texinfo (Target Architecture Definition): Replace > REG_STRUCT_HAS_ADDR with DEPRECATED_REG_STRUCT_HAS_ADDR. It's ok but only once the *-tdep.c files and the corrresponding cross targets have been rebuilt. I checked in the attached. I built all the relevant targets mentioned in MAINTAINERS, that is, all those whose *-tdep.c files I changes, except hppa-elf, which is marked as broken. Sorry for the inconvenience. Mark Index: ChangeLog from Mark Kettenis * cris-tdep.c (cris_gdbarch_init): Set deprecated_reg_struct_has_addr instead of reg_struct_has_addr. * hppa-tdep.c (hppa_gdbarch_init): Likewise. * mcore-tdep.c (mcore_gdbarch_init): Likewise. * mips-tdep.c (mips_gdbarch_init): Likewise. * mn10300-tdep.c (mn10300_gdbarch_init): Likewise. * sparc-tdep.c (sparc_gdbarch_init): Likewise. Index: cris-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/cris-tdep.c,v retrieving revision 1.83 diff -u -p -r1.83 cris-tdep.c --- cris-tdep.c 12 Sep 2003 18:40:16 -0000 1.83 +++ cris-tdep.c 13 Sep 2003 23:20:36 -0000 @@ -4156,7 +4156,7 @@ cris_gdbarch_init (struct gdbarch_info i cris_abi_original_store_return_value); set_gdbarch_deprecated_extract_return_value (gdbarch, cris_abi_original_extract_return_value); - set_gdbarch_reg_struct_has_addr + set_gdbarch_deprecated_reg_struct_has_addr (gdbarch, cris_abi_original_reg_struct_has_addr); } else if (tdep->cris_abi == CRIS_ABI_V2) @@ -4166,8 +4166,8 @@ cris_gdbarch_init (struct gdbarch_info i set_gdbarch_deprecated_store_return_value (gdbarch, cris_abi_v2_store_return_value); set_gdbarch_deprecated_extract_return_value (gdbarch, cris_abi_v2_extract_return_value); - set_gdbarch_reg_struct_has_addr (gdbarch, - cris_abi_v2_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, cris_abi_v2_reg_struct_has_addr); } else internal_error (__FILE__, __LINE__, "cris_gdbarch_init: unknown CRIS ABI"); Index: hppa-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/hppa-tdep.c,v retrieving revision 1.93 diff -u -p -r1.93 hppa-tdep.c --- hppa-tdep.c 11 Sep 2003 15:17:15 -0000 1.93 +++ hppa-tdep.c 13 Sep 2003 23:20:39 -0000 @@ -5119,7 +5119,8 @@ hppa_gdbarch_init (struct gdbarch_info i set_gdbarch_deprecated_call_dummy_length (gdbarch, hppa32_call_dummy_length); set_gdbarch_deprecated_stack_align (gdbarch, hppa32_stack_align); - set_gdbarch_reg_struct_has_addr (gdbarch, hppa_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, hppa_reg_struct_has_addr); set_gdbarch_deprecated_extract_return_value (gdbarch, hppa32_extract_return_value); set_gdbarch_use_struct_convention Index: mcore-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mcore-tdep.c,v retrieving revision 1.74 diff -u -p -r1.74 mcore-tdep.c --- mcore-tdep.c 9 Sep 2003 04:41:32 -0000 1.74 +++ mcore-tdep.c 13 Sep 2003 23:20:39 -0000 @@ -1115,7 +1115,8 @@ mcore_gdbarch_init (struct gdbarch_info set_gdbarch_believe_pcc_promotion (gdbarch, 1); /* MCore will never pass a sturcture by reference. It will always be split between registers and stack. */ - set_gdbarch_reg_struct_has_addr (gdbarch, mcore_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, mcore_reg_struct_has_addr); /* Should be using push_dummy_call. */ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp); Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.229 diff -u -p -r1.229 mips-tdep.c --- mips-tdep.c 12 Sep 2003 18:40:17 -0000 1.229 +++ mips-tdep.c 13 Sep 2003 23:20:42 -0000 @@ -5898,8 +5898,8 @@ mips_gdbarch_init (struct gdbarch_info i set_gdbarch_long_bit (gdbarch, 32); set_gdbarch_ptr_bit (gdbarch, 32); set_gdbarch_long_long_bit (gdbarch, 64); - set_gdbarch_reg_struct_has_addr (gdbarch, - mips_o32_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, mips_o32_reg_struct_has_addr); set_gdbarch_use_struct_convention (gdbarch, always_use_struct_convention); break; @@ -5917,8 +5917,8 @@ mips_gdbarch_init (struct gdbarch_info i set_gdbarch_long_bit (gdbarch, 32); set_gdbarch_ptr_bit (gdbarch, 32); set_gdbarch_long_long_bit (gdbarch, 64); - set_gdbarch_reg_struct_has_addr (gdbarch, - mips_o32_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, mips_o32_reg_struct_has_addr); set_gdbarch_use_struct_convention (gdbarch, always_use_struct_convention); break; case MIPS_ABI_EABI32: @@ -5935,8 +5935,8 @@ mips_gdbarch_init (struct gdbarch_info i set_gdbarch_long_bit (gdbarch, 32); set_gdbarch_ptr_bit (gdbarch, 32); set_gdbarch_long_long_bit (gdbarch, 64); - set_gdbarch_reg_struct_has_addr (gdbarch, - mips_eabi_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, mips_eabi_reg_struct_has_addr); set_gdbarch_use_struct_convention (gdbarch, mips_eabi_use_struct_convention); break; @@ -5954,8 +5954,8 @@ mips_gdbarch_init (struct gdbarch_info i set_gdbarch_long_bit (gdbarch, 64); set_gdbarch_ptr_bit (gdbarch, 64); set_gdbarch_long_long_bit (gdbarch, 64); - set_gdbarch_reg_struct_has_addr (gdbarch, - mips_eabi_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, mips_eabi_reg_struct_has_addr); set_gdbarch_use_struct_convention (gdbarch, mips_eabi_use_struct_convention); break; @@ -5975,8 +5975,8 @@ mips_gdbarch_init (struct gdbarch_info i set_gdbarch_long_long_bit (gdbarch, 64); set_gdbarch_use_struct_convention (gdbarch, mips_n32n64_use_struct_convention); - set_gdbarch_reg_struct_has_addr (gdbarch, - mips_n32n64_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, mips_n32n64_reg_struct_has_addr); break; case MIPS_ABI_N64: set_gdbarch_push_dummy_call (gdbarch, mips_n32n64_push_dummy_call); @@ -5994,8 +5994,8 @@ mips_gdbarch_init (struct gdbarch_info i set_gdbarch_long_long_bit (gdbarch, 64); set_gdbarch_use_struct_convention (gdbarch, mips_n32n64_use_struct_convention); - set_gdbarch_reg_struct_has_addr (gdbarch, - mips_n32n64_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, mips_n32n64_reg_struct_has_addr); break; default: internal_error (__FILE__, __LINE__, Index: mn10300-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mn10300-tdep.c,v retrieving revision 1.87 diff -u -p -r1.87 mn10300-tdep.c --- mn10300-tdep.c 9 Sep 2003 04:41:32 -0000 1.87 +++ mn10300-tdep.c 13 Sep 2003 23:20:43 -0000 @@ -1209,7 +1209,8 @@ mn10300_gdbarch_init (struct gdbarch_inf set_gdbarch_deprecated_sizeof_call_dummy_words (gdbarch, sizeof (mn10300_call_dummy_words)); set_gdbarch_deprecated_pc_in_call_dummy (gdbarch, deprecated_pc_in_call_dummy_at_entry_point); set_gdbarch_deprecated_push_arguments (gdbarch, mn10300_push_arguments); - set_gdbarch_reg_struct_has_addr (gdbarch, mn10300_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, mn10300_reg_struct_has_addr); set_gdbarch_deprecated_push_return_address (gdbarch, mn10300_push_return_address); set_gdbarch_deprecated_save_dummy_frame_tos (gdbarch, generic_save_dummy_frame_tos); set_gdbarch_use_struct_convention (gdbarch, mn10300_use_struct_convention); Index: sparc-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/sparc-tdep.c,v retrieving revision 1.123 diff -u -p -r1.123 sparc-tdep.c --- sparc-tdep.c 11 Sep 2003 15:17:15 -0000 1.123 +++ sparc-tdep.c 13 Sep 2003 23:20:45 -0000 @@ -3285,7 +3285,8 @@ sparc_gdbarch_init (struct gdbarch_info set_gdbarch_deprecated_pop_frame (gdbarch, sparc_pop_frame); set_gdbarch_deprecated_push_return_address (gdbarch, sparc_push_return_address); set_gdbarch_deprecated_push_dummy_frame (gdbarch, sparc_push_dummy_frame); - set_gdbarch_reg_struct_has_addr (gdbarch, sparc_reg_struct_has_addr); + set_gdbarch_deprecated_reg_struct_has_addr + (gdbarch, sparc_reg_struct_has_addr); set_gdbarch_return_value_on_stack (gdbarch, sparc_return_value_on_stack); set_gdbarch_deprecated_saved_pc_after_call (gdbarch, sparc_saved_pc_after_call); set_gdbarch_prologue_frameless_p (gdbarch, sparc_prologue_frameless_p);