From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23806 invoked by alias); 13 Sep 2003 11:03:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23791 invoked from network); 13 Sep 2003 11:03:10 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 13 Sep 2003 11:03:10 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h8DB30xA007989; Sat, 13 Sep 2003 13:03:00 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h8DB30JA077849; Sat, 13 Sep 2003 13:03:00 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h8DB2xvx077846; Sat, 13 Sep 2003 13:02:59 +0200 (CEST) Date: Sat, 13 Sep 2003 11:03:00 -0000 Message-Id: <200309131102.h8DB2xvx077846@elgar.kettenis.dyndns.org> From: Mark Kettenis To: cgf@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <20030913022759.GA2225@redhat.com> (message from Christopher Faylor on Fri, 12 Sep 2003 22:27:59 -0400) Subject: Re: [PATCH] Properly define SSE registers for cygwin targets References: <20030913022759.GA2225@redhat.com> X-SW-Source: 2003-09/txt/msg00285.txt.bz2 Date: Fri, 12 Sep 2003 22:27:59 -0400 From: Christopher Faylor Checked in, trunk and branch. cgf 2003-09-12 Christopher Faylor * win32-nat.c: Reorganize so that defines used by target headers are actually defined by the system headers. * config/i386/tm-cygwin.h: Check for CONTEXT_EXTENDED_REGISTERS rather than HAVE_CONTEXT_EXTENDED_REGISTERS, since the latter actually exists. Hmm, this looks like a lost opportunity to get rid of a definition in tm-cygwin.h. HAVE_SSE_REGS has been eliminated from all source files except win32-nat.c. So a s/HAVE_SSE_REGS/CONTEXT_EXTENDED_REGISTERS/g in that file would have been sufficient. This also removes the need to re-order the includes; out coding standards say that "defs.h" should always come first. Oh and the #include "tm.h" is bogus, since "defs.h" already does that. It would be great if you could clean up things along those lines. The "tm-cygwin.h" still contains a lot of stuff that doesn't belong there. Mark