Re: [rfa/6.0] Fix a thinko in dwarf2loc

Elena Zannoni
2003-09-11T17:16:13Z

Daniel Jacobowitz writes:
> On Tue, Sep 09, 2003 at 06:59:52PM -0400, Andrew Cagney wrote:
> > > > > > > > > + return baton.needs_frame || ctx->in_reg;
> > > > > > > > > }
> > > > > > > > >
> > > > >
> > > > > Hmmm, the ctx just got freed, you cannot dereference it. Need to use a
> > > >
> > > > Eek, I'm embarassed. You are so right.
> > > >
> > > > > local variable. What you are really saying here is that the
> > > > > needs_frame variable is not sufficient to describe what's needed. Can
> > > > > the case be added, so that needs_frame becomes OK? Proabably you
> > > > > need another need_frame_* function.
> > > >
> > > > No, I can't. The needs_frame_* functions are hooks for things which
> > > > are external to the expression evaluator - concepts like "object" and
> > > > "thread local storage address" which require information. But the
> > > > evaluator won't actually try to read from the register when parsing a
> > > > DW_OP_reg1; it just sets in_reg.
> > >
> > >Oh, ok, I guess save ctx->in_reg in a local variable then.
> > >
> > >elena
> >
> > Thanks for picking this up. So there's no confusion I'm also ok with
> > this on the branch.
>
> Thank you both. Checked in.

Just for completeness, can you post the patch?

thanks
elena

>
> --
> Daniel Jacobowitz
> MontaVista Software Debian GNU/Linux Developer