Re: [rfa/6.0] Fix a thinko in dwarf2loc

Andrew Cagney
2003-09-09T22:59:55Z

> > > > > > > + return baton.needs_frame || ctx->in_reg;
> > > > > > > }
> > > > > > >
> > >
> > > Hmmm, the ctx just got freed, you cannot dereference it. Need to use a
> >
> > Eek, I'm embarassed. You are so right.
> >
> > > local variable. What you are really saying here is that the
> > > needs_frame variable is not sufficient to describe what's needed. Can
> > > the case be added, so that needs_frame becomes OK? Proabably you
> > > need another need_frame_* function.
> >
> > No, I can't. The needs_frame_* functions are hooks for things which
> > are external to the expression evaluator - concepts like "object" and
> > "thread local storage address" which require information. But the
> > evaluator won't actually try to read from the register when parsing a
> > DW_OP_reg1; it just sets in_reg.
>
> Oh, ok, I guess save ctx->in_reg in a local variable then.
>
> elena

Thanks for picking this up. So there's no confusion I'm also ok with
this on the branch.

Andrew