From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2985 invoked by alias); 8 Sep 2003 20:20:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2978 invoked from network); 8 Sep 2003 20:20:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 8 Sep 2003 20:20:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.22 #1 (Debian)) id 19wSUX-0007tp-MM; Mon, 08 Sep 2003 16:20:05 -0400 Date: Mon, 08 Sep 2003 20:20:00 -0000 From: Daniel Jacobowitz To: Jimi Xenidis Cc: gdb-patches@sources.redhat.com, Andrew Cagney Subject: Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step Message-ID: <20030908202005.GA30286@nevyn.them.org> Mail-Followup-To: Jimi Xenidis , gdb-patches@sources.redhat.com, Andrew Cagney References: <3F4398EC.2050405@redhat.com> <16195.39851.78762.619597@kitch0.watson.ibm.com> <3F4440F0.30007@redhat.com> <16198.6133.411978.563514@kitch0.watson.ibm.com> <3F463CA9.5000900@redhat.com> <16198.21410.308896.588372@kitch0.watson.ibm.com> <3F465EFD.9020700@redhat.com> <16220.53590.956496.102996@kitch0.watson.ibm.com> <20030908190016.GB24747@nevyn.them.org> <16220.58287.637563.556990@kitch0.watson.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16220.58287.637563.556990@kitch0.watson.ibm.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-09/txt/msg00131.txt.bz2 On Mon, Sep 08, 2003 at 04:16:47PM -0400, Jimi Xenidis wrote: > >>>>> "DJ" == Daniel Jacobowitz writes: > > DJ> On Mon, Sep 08, 2003 at 02:58:30PM -0400, Jimi Xenidis wrote: > >> >>>>> "AC" == Andrew Cagney writes: > >> > AC> What about a patch to eliminate the macros? Good incremental step. > >> > >> Your wish is my (very much delayed) command ;-) > > DJ> Eh, no. This patch would turn on software single-step for GNU/Linux > > This patch simply removes the macro definitions. It does _not_ turn > on software single step for GNU/Linux since the macro tests for the > gdbarch vector which is NULL because it is undefined, but it is > defined for AIX. > > I have verified this by both watching it with gdb and with strace > output. Are you sure you posted the patch you tested? You added a call to set_gdbarch_software_single_step to rs6000_gdbarch_init. It wasn't conditional on anything relating to AIX. By all rights that _should_ set gdbarch_software_singlestep_p for GNU/Linux. > > DJ> also I doubt that's what you wanted to do. > > You are right in that it is not what I wanted when this whole thing > started, but it was suggested that I remove the macro before I propose > the ability to select SW over HW at runtime. > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer