From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29206 invoked by alias); 8 Sep 2003 19:00:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29196 invoked from network); 8 Sep 2003 19:00:17 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 8 Sep 2003 19:00:17 -0000 Received: from drow by nevyn.them.org with local (Exim 4.22 #1 (Debian)) id 19wRFI-0006cB-HR; Mon, 08 Sep 2003 15:00:16 -0400 Date: Mon, 08 Sep 2003 19:00:00 -0000 From: Daniel Jacobowitz To: Jimi Xenidis Cc: gdb-patches@sources.redhat.com, Andrew Cagney Subject: Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step Message-ID: <20030908190016.GB24747@nevyn.them.org> Mail-Followup-To: Jimi Xenidis , gdb-patches@sources.redhat.com, Andrew Cagney References: <16194.58265.207405.586920@kitch0.watson.ibm.com> <20030820030931.GA2109@nevyn.them.org> <3F4398EC.2050405@redhat.com> <16195.39851.78762.619597@kitch0.watson.ibm.com> <3F4440F0.30007@redhat.com> <16198.6133.411978.563514@kitch0.watson.ibm.com> <3F463CA9.5000900@redhat.com> <16198.21410.308896.588372@kitch0.watson.ibm.com> <3F465EFD.9020700@redhat.com> <16220.53590.956496.102996@kitch0.watson.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16220.53590.956496.102996@kitch0.watson.ibm.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-09/txt/msg00126.txt.bz2 On Mon, Sep 08, 2003 at 02:58:30PM -0400, Jimi Xenidis wrote: > >>>>> "AC" == Andrew Cagney writes: > > AC> What about a patch to eliminate the macros? Good incremental step. > > Your wish is my (very much delayed) command ;-) > > Changelog: > > 2003-09-08 Jimi Xenidis > > * config/rs6000/tm-rs6000.h: no longer require custion #define of > SOFTWARE_SINGLE_STEP > * config/powerpc/tm-linux.h: no longer require custion #define of > SOFTWARE_SINGLE_STEP > * rs6000-tdep.c (rs6000_gdbarch_init): Set up software_single_step > while initing gdbarch Eh, no. This patch would turn on software single-step for GNU/Linux also - I doubt that's what you wanted to do. > > Patch: > Index: gdb/rs6000-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v > retrieving revision 1.148 > diff -u -u -r1.148 rs6000-tdep.c > --- gdb/rs6000-tdep.c 18 Aug 2003 20:04:55 -0000 1.148 > +++ gdb/rs6000-tdep.c 8 Sep 2003 17:51:53 -0000 > @@ -3015,6 +3015,9 @@ > /* Hook in ABI-specific overrides, if they have been registered. */ > gdbarch_init_osabi (info, gdbarch); > > + /* RS6000/AIX does not support PT_STEP. Has to be simulated. */ > + set_gdbarch_software_single_step (gdbarch, rs6000_software_single_step); > + > return gdbarch; > } > > Index: gdb/config/powerpc/tm-linux.h > =================================================================== > RCS file: /cvs/src/src/gdb/config/powerpc/tm-linux.h,v > retrieving revision 1.14 > diff -u -u -r1.14 tm-linux.h > --- gdb/config/powerpc/tm-linux.h 3 Sep 2003 21:01:44 -0000 1.14 > +++ gdb/config/powerpc/tm-linux.h 8 Sep 2003 17:51:53 -0000 > @@ -31,12 +31,6 @@ > #undef IN_SOLIB_CALL_TRAMPOLINE > #undef SKIP_TRAMPOLINE_CODE > > -/* We can single step on linux */ > -#undef SOFTWARE_SINGLE_STEP > -#define SOFTWARE_SINGLE_STEP(p,q) internal_error (__FILE__, __LINE__, "Will never execute!") > -#undef SOFTWARE_SINGLE_STEP_P > -#define SOFTWARE_SINGLE_STEP_P() 0 > - > /* Make sure nexti gets the help it needs for debugging assembly code > without symbols */ > > Index: gdb/config/rs6000/tm-rs6000.h > =================================================================== > RCS file: /cvs/src/src/gdb/config/rs6000/tm-rs6000.h,v > retrieving revision 1.26 > diff -u -u -r1.26 tm-rs6000.h > --- gdb/config/rs6000/tm-rs6000.h 3 Sep 2003 21:01:44 -0000 1.26 > +++ gdb/config/rs6000/tm-rs6000.h 8 Sep 2003 17:51:53 -0000 > @@ -90,12 +90,6 @@ > extern CORE_ADDR init_frame_pc_noop (int fromleaf, struct frame_info *prev); > #define DEPRECATED_INIT_FRAME_PC(fromleaf, prev) (init_frame_pc_noop (fromleaf, prev)) > > -/* RS6000/AIX does not support PT_STEP. Has to be simulated. */ > - > -#define SOFTWARE_SINGLE_STEP_P() 1 > -extern void rs6000_software_single_step (enum target_signal, int); > -#define SOFTWARE_SINGLE_STEP(sig,bp_p) rs6000_software_single_step (sig, bp_p) > - > /* Notice when a new child process is started. */ > > #define TARGET_CREATE_INFERIOR_HOOK rs6000_create_inferior > > > > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer