From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23247 invoked by alias); 8 Sep 2003 13:37:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23227 invoked from network); 8 Sep 2003 13:37:28 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 8 Sep 2003 13:37:28 -0000 Received: from drow by nevyn.them.org with local (Exim 4.22 #1 (Debian)) id 19wMCt-0004eh-Mt; Mon, 08 Sep 2003 09:37:27 -0400 Date: Mon, 08 Sep 2003 13:37:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: RFC: selected frame in read_var_value Message-ID: <20030908133727.GA17816@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com References: <20030801192951.GA2109@nevyn.them.org> <3F329038.5040708@redhat.com> <20030828195501.GB27550@nevyn.them.org> <3F58C35A.3060908@redhat.com> <20030907035325.GA9985@nevyn.them.org> <3F5C852D.2010207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F5C852D.2010207@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-09/txt/msg00113.txt.bz2 On Mon, Sep 08, 2003 at 09:33:33AM -0400, Andrew Cagney wrote: > > >Is this about what you wanted, and are my comments on the mark? > > Yes, just one pedantic tweak. > > >If so, how do you feel about a mass replacement of the one deprecated > >construct (deprecated_selected_frame) with the new deprecated construct > >(deprecated_safe_get_selected_frame) in the places in GDB which use > >this "if frame arg is NULL, get selected frame" idiom? > > For 6.0, scares the peverbial out of me -> got a convincing argument? > :-) For the mainline, not phased. I don't know if it's convincing, but I've had one bug reported that would be fixed by it (assertion failure in -data-list-changed-registers). I've got another one to look at now that might be similar. We could just do 'em as they're discovered. > > Andrew > > > >+/* This is a variant of get_selected_frame which can be called when the > >+ inferior is not running; in that case it will return NULL instead of > >+ calling error (). */ > > Almost. Those are also true for a core file. Ooh, that's right of course. I'll revise and commit. > > >+struct frame_info * > >+deprecated_safe_get_selected_frame (void) > >+{ > >+ if (!target_has_registers || !target_has_stack || !target_has_memory) > >+ return NULL; > >+ return get_selected_frame (); > >+} > > > > > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer