From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22204 invoked by alias); 27 Aug 2003 16:16:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22192 invoked from network); 27 Aug 2003 16:16:24 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 27 Aug 2003 16:16:24 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19s2y7-0001XN-Ux; Wed, 27 Aug 2003 12:16:23 -0400 Date: Wed, 27 Aug 2003 16:16:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Jason Merrill , gdb-patches@sources.redhat.com Subject: Re: trivial PATCH to dwarf2read.c:dwarf_attr_name Message-ID: <20030827161623.GA3971@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Jason Merrill , gdb-patches@sources.redhat.com References: <3F4C2BFA.9000108@redhat.com> <3F4CC452.1060100@redhat.com> <20030827154638.GA17095@nevyn.them.org> <3F4CD4F5.9040302@redhat.com> <20030827160238.GA1011@nevyn.them.org> <3F4CD8F8.3060708@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F4CD8F8.3060708@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-08/txt/msg00478.txt.bz2 On Wed, Aug 27, 2003 at 12:14:48PM -0400, Andrew Cagney wrote: > >On Wed, Aug 27, 2003 at 11:57:41AM -0400, Andrew Cagney wrote: > > > >>>Can you please find out. There must be a stronger rationale then "it's > > > >>>>been in my local tree for years". > > > >>> > >>> > >>>Well, the patch is certainly right. GCC generates > >>>DW_AT_MIPS_linkage_name on all targets, and has for as far back as I > >>>have GCC sources to check it. > > > >> > >>Can you please add a comment explaining exactly when/where this occures > >>then? Someone looking that that code is going to assume that > >>DW_AT_MIPS_linkage_name is outside the #ifdef MIPS because of a > >>host/target cross platform problem and _not_ because GCC uses it for all > >>architectures. > > > > > >Actually, I have no idea where the #ifdef MIPS came from, but it should > >be removed. There's no reason to recognize extensions only on a > >specific platform, and their other uses are not protected. > > That's a separate problem. That specific attribute should have gained a > comment explaining how/why it is used by non-MIPS platforms. Otherwize > no one knows what's about to hit them. I have no idea what you mean by "hit". Care to expand? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer