From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28457 invoked by alias); 27 Aug 2003 15:46:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28450 invoked from network); 27 Aug 2003 15:46:40 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 27 Aug 2003 15:46:40 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19s2VL-0007Z1-E9; Wed, 27 Aug 2003 11:46:39 -0400 Date: Wed, 27 Aug 2003 15:46:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Jason Merrill , gdb-patches@sources.redhat.com Subject: Re: trivial PATCH to dwarf2read.c:dwarf_attr_name Message-ID: <20030827154638.GA17095@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Jason Merrill , gdb-patches@sources.redhat.com References: <3F4C2BFA.9000108@redhat.com> <3F4CC452.1060100@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F4CC452.1060100@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-08/txt/msg00474.txt.bz2 On Wed, Aug 27, 2003 at 10:46:42AM -0400, Andrew Cagney wrote: > >On Tue, 26 Aug 2003 23:56:42 -0400, Andrew Cagney > >wrote: > > > > > >>>I'm checking this in under the obvious rule; DW_AT_MIPS_linkage_name is > >>>used on all targets. > >>>2003-08-26 Jason Merrill > >>> * dwarf2read.c (dwarf_attr_name): Move DW_AT_MIPS_linkage_name > >>> case out of #ifdef MIPS block. > >>> > > > >> > >>Jason, exactly what prompted the change? In particular which GCC? > > > > > >I don't remember. I think it's been in my local tree for years. It's > >quite likely that I just noticed it. > > Can you please find out. There must be a stronger rationale then "it's > been in my local tree for years". Well, the patch is certainly right. GCC generates DW_AT_MIPS_linkage_name on all targets, and has for as far back as I have GCC sources to check it. We just don't use dwarf_attr_name much, so it didn't matter. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer