Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com, kettenis@gnu.org
Subject: Re: RFA: lin-lwp cleanup
Date: Wed, 27 Aug 2003 04:00:00 -0000	[thread overview]
Message-ID: <20030827040026.GA23492@nevyn.them.org> (raw)
In-Reply-To: <3F4C150F.8090802@redhat.com>

On Tue, Aug 26, 2003 at 07:18:55PM -0700, Michael Snyder wrote:
> Daniel Jacobowitz wrote:
> >This patch doesn't do anything particularly important.  I just moved some
> >code from stop_wait_callback out to a new function.  I thought I'd need it
> >for my next patch; I turned out not to, but it's still cleaner this way.
> >
> >Also fixes the two small problems I asked Jeff about earlier today - an
> >extra call to lin_lwp_thread_alive and a missing delete_thread.
> >
> >Is this OK?
> >
> 
> There's a bit more here than code movement -- the new code is not
> identical to the old, even allowing for the jjohnstn changes.
> 
> If you'll say a word or two about the differences, I expect I'll approve 
> them.

The differences are exactly those two.  There were two copies of the
code which called delete_lwp, and one of them was missing
delete_thread; so I collapsed them together.  And there was a block
which checked lin_lwp_thread_alive, now gone.

Oh, I changed the text of the first error message from "exited" to
"vanished" so that we could tell from the logs which case was used.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-08-27  4:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-26 19:32 Daniel Jacobowitz
2003-08-27  2:19 ` Michael Snyder
2003-08-27  4:00   ` Daniel Jacobowitz [this message]
2003-08-27 17:38     ` Michael Snyder
2003-08-28 14:20       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030827040026.GA23492@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@gnu.org \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox