From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-26536-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 23597 invoked by alias); 19 Aug 2003 19:38:21 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 23581 invoked from network); 19 Aug 2003 19:38:20 -0000
Received: from unknown (HELO concert.shout.net) (204.253.184.25)
  by sources.redhat.com with SMTP; 19 Aug 2003 19:38:20 -0000
Received: from duracef.shout.net (duracef.shout.net [204.253.184.12])
	by concert.shout.net (8.12.9/8.12.9) with ESMTP id h7JJcFUg014118;
	Tue, 19 Aug 2003 14:38:15 -0500
Received: from duracef.shout.net (localhost [127.0.0.1])
	by duracef.shout.net (8.12.9/8.12.9) with ESMTP id h7JJcFHK023549;
	Tue, 19 Aug 2003 14:38:15 -0500
Received: (from mec@localhost)
	by duracef.shout.net (8.12.9/8.12.9/Submit) id h7JJcED0023548;
	Tue, 19 Aug 2003 15:38:14 -0400
Date: Tue, 19 Aug 2003 19:38:00 -0000
From: Michael Elizabeth Chastain <mec@shout.net>
Message-Id: <200308191938.h7JJcED0023548@duracef.shout.net>
To: jimb@redhat.com
Subject: Re: [rfa] save space by using enum bitfields
Cc: ac131313@redhat.com, drow@mvista.com, ezannoni@redhat.com,
   gdb-patches@sources.redhat.com, msnyder@redhat.com
X-SW-Source: 2003-08/txt/msg00324.txt.bz2

Rats, I found a bug in my patch.  Too bad you didn't approve it
before I found the bug.  :)

The bug is that the old code has some of this:

  struct minimal_symbol
  {
    ...
    enum minimal_symbol_type { ... } type BYTE_BITFIELD;
    ...
  };

My patch has this:

  struct minimal_symbol
  {
    ...
    enum minimal_symbol_type { ... };
    BITFIELD_ENUM(minimal_symbol_type) type : 8
    ...
  };

gcc 3.3.1 emits warnings for the declaration of enum inside struct.
And gcc 3.2-7-rh emits errors for this!

So I have to do:

  enum minimal_symbol_type
  {
    ...
  };

  struct minimal_symbol
  {
    ...
    BITFIELD_ENUM(minimal_symbol_type) type : 8;
  };

I am preparing a new patch now.  It's actually shorter than the
old patch, because I gave up on struct symtab (this is not a
space critical struct and it has one of those pesky embedded
enum definitions, so it's a bunch of patching for little space
savings).

Michael C