From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22763 invoked by alias); 18 Aug 2003 17:17:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22738 invoked from network); 18 Aug 2003 17:17:44 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 18 Aug 2003 17:17:44 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h7IHHZCH011176; Mon, 18 Aug 2003 19:17:35 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h7IHHZF7042449; Mon, 18 Aug 2003 19:17:35 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h7IHHZdq042446; Mon, 18 Aug 2003 19:17:35 +0200 (CEST) Date: Mon, 18 Aug 2003 17:17:00 -0000 Message-Id: <200308181717.h7IHHZdq042446@elgar.kettenis.dyndns.org> From: Mark Kettenis To: mec@shout.net CC: gdb-patches@sources.redhat.com In-reply-to: <200308180942.h7I9gdVM030705@duracef.shout.net> (message from Michael Elizabeth Chastain on Mon, 18 Aug 2003 05:42:39 -0400) Subject: Re: [PATCH] Improve i386 prologue analyzer References: <200308180942.h7I9gdVM030705@duracef.shout.net> X-SW-Source: 2003-08/txt/msg00298.txt.bz2 Date: Mon, 18 Aug 2003 05:42:39 -0400 From: Michael Elizabeth Chastain It works for me. Fixes the bug, no regressions anywhere in the test suite, eight configurations tested (all my gcc's with -gdwarf-2 and -gstabs+). I also took a little test program and stepi'd it through each instruction in select() and the stack trace was good after each instruction. I think this is ready for the branch. Checked in there too. Thanks for testing. But as soon as GCC starts intermingling the moves with the pushes in the prologue we'll lose again. Ah, such is life :-(. Mark