From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13794 invoked by alias); 17 Aug 2003 21:03:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13781 invoked from network); 17 Aug 2003 21:03:52 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 17 Aug 2003 21:03:52 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19oUgl-00035a-Lg; Sun, 17 Aug 2003 17:03:47 -0400 Date: Sun, 17 Aug 2003 21:03:00 -0000 From: Daniel Jacobowitz To: Kei Sakamoto Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] New m32r remote target, m32rsdi Message-ID: <20030817210347.GF11300@nevyn.them.org> Mail-Followup-To: Kei Sakamoto , gdb-patches@sources.redhat.com References: <02e201c35a5e$883a8cb0$5169910a@KEI> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02e201c35a5e$883a8cb0$5169910a@KEI> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-08/txt/msg00281.txt.bz2 On Mon, Aug 04, 2003 at 05:00:55PM +0900, Kei Sakamoto wrote: > Hello, > > The attached adds a new remote target, m32rsdi, which uses > m32r's on-chip debug interface, SDI (Scalable Debug Interface). > > In m32rsdi target mode, gdb does not control a target board > directly. Instead, gdb sends commands to "sdiserver" by sockets > interface. Sdiserver is a program which controls the target > board using printer ports. > > Is this OK to commit? > > Kei Sakamoto > > ==== > > 2003-08-04 Kei Sakamoto > > > * remote-m32r-sdi.c : New file, interface to m32r on-chip > debug interface, SDI (Scalable Debug Interface). > * Makefile.in (remote-m32r-sdi.o): Add build rule. > * config/m32r/m32r.mt (TDEPFILES) : Add remote-m32r-sdi.o. I don't feel qualified to review a new remote target, so you'll have to ask the remote maintainer. However, there's definitely a problem with the new code. It's full of pieces like: if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) *((unsigned long *) (buf + 1)) = pc_addr; else *((unsigned long *) (buf + 1)) = pc_addr - 1; This sends host-endian data over the wire to the target. Run it on a big-endian host and bad things will happen. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer